Update RecursiveBinder.Spoon init.lua #324
Open
zhsfei wants to merge 1 commit intoHammerspoon:masterfrom
Open
Conversation
Repeated binding, resulting in slowdown
cmsj
requested changes
Oct 10, 2024
| modal:bind(obj.escapeKey[1], obj.escapeKey[2], function() modal:exit() killHelper() end) | ||
|
|
||
| -- Repeated binding, resulting in slowdown | ||
| -- modal:bind(obj.escapeKey[1], obj.escapeKey[2], function() modal:exit() killHelper() end) |
Member
There was a problem hiding this comment.
I think it would be better to just remove this, rather than commenting it out.
| keyFuncNameTable[createKeyName(key)] = key[3] | ||
| end | ||
| end | ||
| -- fix repeat bind |
Member
There was a problem hiding this comment.
I think this comment isn't helpful - it would be better to say what is happening now, rather than what was fixed.
For example:
-- Bind Escape key to exit modal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated binding, resulting in slowdown