Replace WMI-powered filesystem compression by BinToss · Pull Request #292 · HaloSPV3/HXE

BinToss · 2022-03-14T10:27:02Z

closes #253

Utilizes https://github.com/dotnet/pinvoke

TODO

Test via CLI switch
hook into Installer.cs
handle Access/Security exceptions
handle "File/Directory in use" access exceptions

github-actions · 2022-03-14T10:28:44Z

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist	Active	Result
Pull request is a draft and should be ignored	✅	✅
Pull request is made by a whitelisted user and should be ignored	✅	❌
Pull request is submitted by a bot and should be ignored	✅	❌
Pull request is submitted by administrators and should be ignored	❌	❌

Result

Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped.

github-actions · 2022-03-15T07:35:27Z

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist	Active	Result
Pull request is a draft and should be ignored	✅	✅
Pull request is made by a whitelisted user and should be ignored	✅	❌
Pull request is submitted by a bot and should be ignored	✅	❌
Pull request is submitted by administrators and should be ignored	❌	❌

Result

Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped.

github-actions · 2022-03-15T08:12:52Z

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist	Active	Result
Pull request is a draft and should be ignored	✅	✅
Pull request is made by a whitelisted user and should be ignored	✅	❌
Pull request is submitted by a bot and should be ignored	✅	❌
Pull request is submitted by administrators and should be ignored	❌	❌

Result

Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped.

github-actions · 2022-03-21T08:14:22Z

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist	Active	Result
Pull request is a draft and should be ignored	✅	✅
Pull request is made by a whitelisted user and should be ignored	✅	❌
Pull request is submitted by a bot and should be ignored	✅	❌
Pull request is submitted by administrators and should be ignored	❌	❌

Result

Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped.

github-actions · 2022-03-21T10:46:55Z

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist	Active	Result
Pull request is a draft and should be ignored	✅	✅
Pull request is made by a whitelisted user and should be ignored	✅	❌
Pull request is submitted by a bot and should be ignored	✅	❌
Pull request is submitted by administrators and should be ignored	❌	❌

Result

Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped.

github-actions · 2022-04-10T10:44:36Z

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist	Active	Result
Pull request is a draft and should be ignored	✅	✅
Pull request is made by a whitelisted user and should be ignored	✅	❌
Pull request is submitted by a bot and should be ignored	✅	❌
Pull request is submitted by administrators and should be ignored	❌	❌

Result

Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped.

BinToss · 2022-04-10T10:49:18Z

https://twitter.com/VoidsShadow/status/1513087907145269249
Directory handles can now be acquired properly.
Next step: handle "resource is in use by another process" exceptions

github-actions · 2022-04-17T11:43:54Z

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist	Active	Result
Pull request is a draft and should be ignored	✅	✅
Pull request is made by a whitelisted user and should be ignored	✅	❌
Pull request is submitted by a bot and should be ignored	✅	❌
Pull request is submitted by administrators and should be ignored	❌	❌

Result

Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped.

no clue how this works

Added extension methods: DirectoryInfo.Compress() FileInfo.Compress() Reworked methods: SetCompression() (formerly EnableCompression())

…tatus

…ationException docs: fill IsElevated doc elements

refactor: remove redundant InfoWin32Exception class

Why did I change this to .NET Framework 4.6.2?

BinToss · 2023-05-27T10:40:12Z

Suggested edit:

diff --git a/src/HXE.csproj b/src/HXE.csproj
index c66e9f5..4194a86 100644
--- a/src/HXE.csproj
+++ b/src/HXE.csproj
@@ -118,7 +118,7 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="Microsoft.Windows.CsWin32" Version="0.1.635-beta">
+    <PackageReference Include="Microsoft.Windows.CsWin32" Version="0.2.252-beta">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>

Why did I change this to .NET Framework 4.6.2?

This reverts commit a40015a.

…beta

# Conflicts: # src/HXE.csproj

…n README.md

docs: update SetCompression's docs

CsWin32's code gen was not running with this property present.

BinToss force-pushed the fix/fscompression branch from 5881ecd to 3fbeba7 Compare March 15, 2022 07:34

BinToss force-pushed the fix/fscompression branch from 3fbeba7 to 80b7a85 Compare March 15, 2022 08:11

BinToss force-pushed the fix/fscompression branch from 80b7a85 to 371d78a Compare March 21, 2022 08:12

BinToss force-pushed the fix/fscompression branch from 371d78a to 038ec7b Compare March 21, 2022 10:45

BinToss linked an issue Apr 10, 2022 that may be closed by this pull request

Replace non-WMI filesystem compression implemented in b31efb95 #253

Open

BinToss mentioned this pull request Apr 20, 2022

Linux compatibility HaloSPV3/SPV3.Loader#54

Open

9 tasks

BinToss force-pushed the fix/fscompression branch from de4a55c to 4791ae0 Compare May 26, 2023 07:39

BinToss force-pushed the develop branch from 3910e97 to 13e73c1 Compare May 26, 2023 07:39

BinToss force-pushed the fix/fscompression branch from 4791ae0 to 099daa2 Compare May 27, 2023 00:45

BinToss force-pushed the develop branch from 13e73c1 to 3e769c3 Compare May 27, 2023 00:46

BinToss added 12 commits May 26, 2023 18:09

refactor: add FSCrompression, uses PInvoke

9edb6e2

no clue how this works

refactor: make FSCompression static

a56dd63

refactor: rename FileSystemCompression

3c89746

build: AllowUnsafeBlocks

8684200

build: add PackageReference pinvoke.kernel32

ada6dee

refactor: overhaul FileSystemCompression class

0702827

Added extension methods: DirectoryInfo.Compress() FileInfo.Compress() Reworked methods: SetCompression() (formerly EnableCompression())

build: re-add Fody, Costura.Fody

a40015a

build(deps): fix name of PInvoke.Kernel32

836e92f

refactor: change DirectoyInfo.Compress()'s progress from Int to HXE.S…

743e558

…tatus

fix: increment Compress()'s status properly

2924353

fix: replace enableLZNT1 procedure

4fffd4d

feat: add --applyLznt1= CLI parameter

97592cd

refactor: add exception-throwing wrapper of CreateFile

b6e5f2b

BinToss force-pushed the fix/fscompression branch from 099daa2 to b6e5f2b Compare May 27, 2023 01:10

BinToss added 5 commits May 26, 2023 18:35

refactor: replace IsElevated's NotSupportedException with InvalidOper…

5cf8904

…ationException docs: fill IsElevated doc elements

fix: call GetLastPInvokeError instead of GetLastWin32Error

7fadb34

refactor: remove redundant InfoWin32Exception class

build: set TargetFramework back to net6.0

27260ec

Why did I change this to .NET Framework 4.6.2?

docs: make custom 'TokenAccessMask' inheritdoc as much as possible

6c53853

fix: fix reference to TokenAccessMask.Query

58334c8

BinToss added 17 commits May 27, 2023 03:57

build: set TargetFramework back to net6.0

aae7666

Why did I change this to .NET Framework 4.6.2?

build: switch to net6.0-windows until we can get rid of WPF

471e74d

build: use latest C# language version

2e9b309

build: remove redundant property 'Deterministic'

40f48e2

revert(deps): "build: re-add Fody, Costura.Fody"

946bbff

This reverts commit a40015a.

build(deps): update dependency microsoft.windows.cswin32 to v0.2.252-…

4c74ded

…beta

build(deps): update PInvoke monorepo to v0.7.124

52126a8

Merge branch 'updateBuildConfig' into hotfix/fscompression

579dfc0

# Conflicts: # src/HXE.csproj

chore(vscode): update launch configs to net6.0-windows/win7-x86

1cfa07a

chore(vscode): restrict launch config 'Debug LZNT1' to operate only o…

4b331d8

…n README.md

Merge branch 'updateVscodeConfig' into hotfix/fscompression

b479c92

refactor: wrap some specific SET_COMPRESSION errors

b7695b1

docs: update SetCompression's docs

fix: return GetHandle's FileStream to dispose it later

d0cb357

docs: update SetSeBackupPrivilege documentation

f856cc9

build(deps): re-add CsWin32's PrivateAssets property

489a11d

build: enable prop EmitCompilerGeneratedFiles

04e1953

build: comment out prop TargetFrameworks

4045c34

CsWin32's code gen was not running with this property present.

BinToss self-assigned this May 27, 2023

BinToss added 4 commits May 27, 2023 16:59

fix: update PInvoke, CsWin32 references

07c58c6

feat: add SharingViolationException

abca804

refactor: improve GetHandle exception messages

9486b41

refactor: change SubItems to class

4f07f2f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace WMI-powered filesystem compression#292

Replace WMI-powered filesystem compression#292
BinToss wants to merge 52 commits into
developfrom
fix/fscompression

BinToss commented Mar 14, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 14, 2022

Uh oh!

github-actions Bot commented Mar 15, 2022

Uh oh!

github-actions Bot commented Mar 15, 2022

Uh oh!

github-actions Bot commented Mar 21, 2022

Uh oh!

github-actions Bot commented Mar 21, 2022

Uh oh!

github-actions Bot commented Apr 10, 2022

Uh oh!

BinToss commented Apr 10, 2022

Uh oh!

github-actions Bot commented Apr 17, 2022

Uh oh!

BinToss commented May 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

BinToss commented Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

github-actions Bot commented Mar 14, 2022

Pull Request Validation Report

Whitelist Report

Uh oh!

github-actions Bot commented Mar 15, 2022

Pull Request Validation Report

Whitelist Report

Uh oh!

github-actions Bot commented Mar 15, 2022

Pull Request Validation Report

Whitelist Report

Uh oh!

github-actions Bot commented Mar 21, 2022

Pull Request Validation Report

Whitelist Report

Uh oh!

github-actions Bot commented Mar 21, 2022

Pull Request Validation Report

Whitelist Report

Uh oh!

github-actions Bot commented Apr 10, 2022

Pull Request Validation Report

Whitelist Report

Uh oh!

BinToss commented Apr 10, 2022

Uh oh!

github-actions Bot commented Apr 17, 2022

Pull Request Validation Report

Whitelist Report

Uh oh!

BinToss commented May 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BinToss commented Mar 14, 2022 •

edited

Loading