Improve manager `game()` update loop latency #347

truell20 · 2016-12-23T04:24:46Z

Taking around 30 sec for each game.

Janzert · 2016-12-23T19:54:34Z

Have you narrowed it down at all to where the time is being spent?

Local testing that otherwise mimics the live user and game counts, but skips the aws upload of replays, completes the call in an average time of about 1 second¹. If it is the replay upload time I'm not sure what could have caused that to change from earlier on.

¹ Actually less since that 1 second is the time from completion of one game on the worker to the time of starting the next. So it also includes the time to get the next game task.

truell20 · 2016-12-23T20:04:34Z

Added some logging. AWS upload seems to be taking less than a second.

truell20 · 2016-12-23T20:13:34Z

I've isolated it to the section were ranks are calculated and stored in the db. This is under:

// Update overall rank of everyone

Odd that that isn't latent on your local setup with many users.

truell20 · 2016-12-23T20:16:39Z

Specifically, the latent section is all of the update queries sent to the db. Not the sorting all of the users according to rank.

Janzert · 2016-12-23T20:20:33Z

I'll try and dig into it this evening. The test above was done on the branch with player seed locking, but that should only add more time and effort taken.

One thought, I don't have any inactive users, only 1000 active isRunning=1 users, most with one submission each.

@nmalaguti

* Add actual map size reporting. * Parse width and heights as ints. Fix test. * add verst to organizationWhitelist.txt * Update the description of quiet mode output. * Update organizationWhitelist.txt * Count number of workers down * Take apostrophe out of website * Limited # of characters accepted by getString() Limit presently set at 24000 * Put a random bot replay on intro halite * Update basics_intro_halite * Fixes to ErrorFilterCompiler * Fixed some networking bugs * Fixed env such that "boom.py" no longer breaks it * Fix to updateOrgs * Take out "Final map size:" * Require equality in worker tests * Update organizationWhitelists.txt Added my company name qure.ai to the whitelist. * Include xss script in electron visualizer. * Use a colorblind safe palatte for the visualizer. * Closes HaliteChallenge#347 * Add interview waiving note * Initial pull-mu-sigma with some related refactoring * Update README.md * Store the last 500,000 games * Update color palette after more feedback. * parsereplay.js indentation * Revert "Merge branch 'colorblind'" This reverts commit ca2b332, reversing changes made to f8aa93f. * One more visualizer color change. * Switch to lighter cyan. * Reinstate debugging disabled code. * Fix formatting. * Possible runaway crash bot fix. * Update advanced_third_party.php * Add in fix to sametine problem * Add num users * Add in num submissions * Revert "Add in num submissions" This reverts commit 8433141. * Revert "Add num users" This reverts commit 4ef3011. * Update organizationWhitelist.txt * Update INSTALL.md * Update third party list * Update titles * Small latency fix to tier picking * Update advanced_third_party.php * Replay file dumps and third party edits * Adding association window and capabilities * Add @nmalaguti's visualizer * Change numRows back practice * Add KalraA's new tutorial * Update organizationWhitelist.txt * Update advanced_third_party.php * Add number of coders on the homepage * try out an increase in memory * added -r for no replay, added -i for replay directory * added -r for no replay, added -i for replay directory * typo * Indentation * JS run fix * Make dummy data easier to deal with * Performance improvement for Java Starter Package: Got rid of object churn The current implementation of the java starter package has the disadvantage that it produces a lot of object churn mainly because the game map is re-created upon each turn. This commit prevents the object churn by creating the game map, locations, and sites once and updating them later on. * Changed replay to a new favorite * Changed default speed for homepage vis * Trying another color scheme * Colors (hopefully) fixed * popped out 1&4 * Dropped HaliteChallenge#11 * -i no longer requires lagging / and supports " * Killed light green * Center initial player positions in the visualizer. * Revert "Performance improvement for Java Starter Package: Got rid of object churn" * Update downloads.php * Initial inclusion of nmalaguti's extra visualizer graphs. * Adding Edinburgh to orgs * Fix vis fps bug Now limits to 20 when idle to decrease lag using <> and mouse when paused. * Make sponsor images smaller * Clear graphics before toggling extra graphs. * Force a render after clearing graphics before changing graphs. * Improve speed of game parsing. * Fix parsereplay.js's indentation * Scala starter package bug: Fix size parsing for unequal width/height Added utilities in Grid that I've found useful so far. * Performance improvement for Java Starter Package: Got rid of object churn The current implementation of the java starter package has the disadvantage that it produces a lot of object churn mainly because the game map is re-created upon each turn. This commit prevents the object churn by creating the game map, locations, and sites once and updating them later on. * Changed visibility of var production in Site from private to to public * Stop indirect mutation of gameMap. * Allow loading another replay after starting one in the local visualizers. * Update about.php * Update about.php * Typo * Make the cumulative graphs, cumulative on the final frame. * Make trueskill updates dependant on numSubmissions not changing. This should solve a race condition when a new submission comes in after a game has already been accepted but not yet had trueskill updated. * Fix visualizer maxHeight calculation when not using minimal display. * Leave space for the file select button. * Take scrimmage out of UI * Fully remove scrimmages from the UI * Take out unnecesary associate.php code * Force associate on sign up * Bump up worker limit * Add levels to leaderboard * Take out currently unneeded scrimmage and high school code * Revert "Take out currently unneeded scrimmage and high school code" This reverts commit 6c43d76. * Remove currently unneeded scrimmage code * Fully remove scrimmages from the db * Remove unnecessary level logic * Take out bold associate styling * Add back j-clap's proper organization reporting * wait message * Fixes * Bump user to server ratio * Put level before org * Update associate.js * Adding University of Bordeaux * Added University of Bordeaux (student addresses) * Fix symlinks in visualizer/lib * add wargaming.net organization * Change Horace Mann name * Fix to updateOrgs.py * Adding UoE students forgot to include them before >.> * Fix extended graph off by one error. * Refining association page and adding an email request button * Revert "Revert "Add num users"" This reverts commit 515152a. * Default user value to prevent caching problems * Update end date * Bumped Init time to 30 sec * Add ./ to julia runGame.sh * Archive starter package julia fix * Fix * Hopefully fixes CI * Janzert CI fix * Make CI patch nicer * On the user page, always show if a bot errored in a game. * Add dash to error column * Eliminate error column in user page gamelist. * Show mark if any opponents error out of a game. * Add number of others that also errored out in tooltip. * Changed make.bat to @nmalaguti's * Moved back but modified... hoping for appveyor * added appveyor.yml * Perhaps fixed spacing? * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update make.bat * Update appveyor.yml * build * Changed Windows download to link to Appveyor * switched to static build * Updated version number [build] * Add Grand Valley State University to whitelist * add aqr to the whitelist * Return GameUser.versionNumber in api/web/game results. * Force ssh host key accept * Added derivco * Added Nerdery * Added URochester * End date clarification * Add another harvard email * Script to reset all user ranks and scores. * Add median mu and sigma to status page. * Stick with old stable phpunit that will work with php 5.6. * Use versioned filenamefor phpunit. * Changes to manager task api for finals. Add setting to stop game tasks being handed out. Add setting to change to uniform seeding for the finals. * Script to check for tasks completion. * Print out last gameID after all tasks completed. * Add option to close submissions in the web api. * Only display bot submit button when bot submissions are open. Also fixes config section name in WebsiteAPI.php for closing submissions. * Add alfred's suggestions * Add 'tentative' * More games allowed * Try bumped timeouts * Revert "Try bumped timeouts" This reverts commit f09e12c. * Add Erdman's Halite Lint to third party tools * Seed Players above 1000 * Add workerID to Game * Top 500 seed * We are now at 200 games; Limit finals to silver and above * Halite end note * Added Citi from email request

truell20 added game servers priority labels Dec 23, 2016

truell20 closed this as completed in 2f591af Dec 23, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve manager `game()` update loop latency #347

Improve manager `game()` update loop latency #347

truell20 commented Dec 23, 2016

Janzert commented Dec 23, 2016 •

edited

Loading

truell20 commented Dec 23, 2016

truell20 commented Dec 23, 2016 •

edited

Loading

truell20 commented Dec 23, 2016 •

edited

Loading

Janzert commented Dec 23, 2016

Improve manager game() update loop latency #347

Improve manager game() update loop latency #347

Comments

truell20 commented Dec 23, 2016

Janzert commented Dec 23, 2016 • edited Loading

truell20 commented Dec 23, 2016

truell20 commented Dec 23, 2016 • edited Loading

truell20 commented Dec 23, 2016 • edited Loading

Janzert commented Dec 23, 2016

Improve manager `game()` update loop latency #347

Improve manager `game()` update loop latency #347

Janzert commented Dec 23, 2016 •

edited

Loading

truell20 commented Dec 23, 2016 •

edited

Loading

truell20 commented Dec 23, 2016 •

edited

Loading