Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ray collision #79

Merged
merged 27 commits into from
Aug 14, 2021
Merged

Ray collision #79

merged 27 commits into from
Aug 14, 2021

Conversation

Anomalous-Creator
Copy link
Collaborator

@Anomalous-Creator Anomalous-Creator commented Jun 29, 2021

No description provided.

@Anomalous-Creator Anomalous-Creator added the wait for author Used for when a PR isn't ready for review yet label Jun 29, 2021
@erickbickler
Copy link
Collaborator

erickbickler commented Jun 30, 2021

Can you please go through and add comments explaining the logic? Also resolve conflicts when you get the chance to checks can run

@erickbickler erickbickler linked an issue Jun 30, 2021 that may be closed by this pull request
@erickbickler erickbickler linked an issue Jul 7, 2021 that may be closed by this pull request
Copy link
Owner

@HagenSR HagenSR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some preliminary PR review. Will check the controller part later

game/controllers/ray_controller.py Outdated Show resolved Hide resolved
game/common/game_board.py Outdated Show resolved Hide resolved
game/common/game_board.py Outdated Show resolved Hide resolved
Base automatically changed from dev to master July 8, 2021 20:47
@erickbickler erickbickler changed the base branch from master to dev July 8, 2021 21:07
@erickbickler
Copy link
Collaborator

erickbickler commented Aug 5, 2021

It's been over a month since opening and over a week since last commit, is this close to completion? This needs to be finished.

@Anomalous-Creator Anomalous-Creator removed the wait for author Used for when a PR isn't ready for review yet label Aug 6, 2021
Copy link
Owner

@HagenSR HagenSR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this controller to the master controller game loop logic. Also fails to run after pulling the latest dev

Copy link
Owner

@HagenSR HagenSR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs, looks good

Copy link
Collaborator

@erickbickler erickbickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would still like to see more comments, but we need this so I'll approve it. Can we get documentation on how this is supposed to be used

@erickbickler erickbickler merged commit ef0c492 into dev Aug 14, 2021
@erickbickler erickbickler deleted the Ray-Collision branch August 14, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish Hit Detection Algorithm Create hit detection algorithm
4 participants