fix: prevent Safari auto-translate from breaking calendar #6168
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add translate="no" attribute to the CalendarContainer root element to prevent browser auto-translation features from interfering with the calendar's date rendering and navigation. When Safari's auto-translate is enabled, it attempts to translate the calendar's date/month names, which breaks React's virtual DOM reconciliation and causes "NotFoundError: The object can not be found here" errors and blank pages when navigating months. The translate="no" attribute is a standard HTML attribute that tells browsers not to translate the content within the element. This allows the library's own localization (via date-fns locales) to work correctly. Fixes #5824 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6168 +/- ##
=======================================
Coverage 99.26% 99.26%
=======================================
Files 30 30
Lines 3792 3792
Branches 1631 1631
=======================================
Hits 3764 3764
Misses 27 27
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
translate="no"attribute to the CalendarContainer root elementProblem
When Safari's auto-translate feature is enabled, it attempts to translate the calendar's date/month names. This breaks React's virtual DOM reconciliation and causes:
Solution
The
translate="no"attribute is a standard HTML attribute that tells browsers not to translate the content within the element. This allows the library's own localization (via date-fns locales) to work correctly while preventing browser translation interference.Test Plan
translate="no"attribute is presentBrowser Support
The
translateattribute is supported in all modern browsers including Safari, Chrome, Firefox, and Edge.Fixes #5824
🤖 Generated with Claude Code