Skip to content

Conversation

@martijnrusschen
Copy link
Member

Summary

This PR adds tests to document the existing behavior that openToDate can be used to specify the default date when showTimeSelectOnly is true and selected is null.

Background

Issue #6032 requested a way to specify a default date when using showTimeSelectOnly with a null selected value. The user wanted to set a specific date (e.g., 2025-11-01) that would be used when a time is selected, instead of defaulting to the current date.

Good news: This feature already exists! The openToDate prop can be used for exactly this purpose.

Example Usage

<DatePicker
  selected={null}
  openToDate={new Date("2025-11-01")}
  onChange={(date) => console.log(date)}
  showTimeSelect
  showTimeSelectOnly
/>

When the user selects a time (e.g., 09:06), the resulting date will be 2025-11-01 09:06:00 instead of {today} 09:06:00.

Tests Added

  • should use openToDate as the base date when selecting time with showTimeSelectOnly and selected is null
  • should use current date when showTimeSelectOnly is true and neither selected nor openToDate is provided
  • should use openToDate for showTimeInput when selected is null

Closes #6032

🤖 Generated with Claude Code

Added tests to verify that openToDate can be used to specify the default
date when showTimeSelectOnly is true and selected is null. This documents
the existing behavior that addresses the feature request in #6032.

Tests added:
- openToDate as base date with showTimeSelectOnly and null selected
- Current date fallback when neither selected nor openToDate provided
- openToDate with showTimeInput and null selected

Closes #6032

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.25%. Comparing base (8b66e0d) to head (0398e79).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6157   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          30       30           
  Lines        3783     3783           
  Branches     1627     1644   +17     
=======================================
  Hits         3755     3755           
  Misses         27       27           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martijnrusschen martijnrusschen merged commit 09e785c into main Dec 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specify the default date when showTimeSelectOnly is at true and default value is null

2 participants