Skip to content

Conversation

@stropitek
Copy link
Contributor

@stropitek stropitek commented Dec 16, 2025

  • fix: correct react-datepicker children which use em units
  • fix: do not set custom calendar styles in portal

Description

Closes: #6140

Changes
I made it such that properties which depend on the font size by using em units have values which match those of v8, as those were significantly shrunk.
I changed a doc example to show how a different font size affects the result.

I also fixed the portal, which was too big. I think previously the portal was rendered bigger on purpose, but I think this is something the user can customize if needed, not something the lib should do by default (changing style based on portal option is not something I would expect).

Screenshots

Before / After

Normal

Before:
CleanShot 2025-12-16 at 16 33 18

After:
CleanShot 2025-12-16 at 16 27 30

Custom calendar styles:
Before:
CleanShot 2025-12-16 at 16 27 50

After (with a custom, larger font size on the calendar element):
CleanShot 2025-12-16 at 16 27 20

Portal
Before:
CleanShot 2025-12-16 at 16 28 02

After:
CleanShot 2025-12-16 at 16 28 20

To reviewers

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.26%. Comparing base (7d76c6d) to head (d868aeb).
⚠️ Report is 44 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6144   +/-   ##
=======================================
  Coverage   99.25%   99.26%           
=======================================
  Files          30       30           
  Lines        3782     3792   +10     
  Branches     1627     1648   +21     
=======================================
+ Hits         3754     3764   +10     
  Misses         27       27           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stropitek stropitek marked this pull request as ready for review December 16, 2025 15:38
@martijnrusschen
Copy link
Member

besides the comment, the PR looks good to go

@martijnrusschen martijnrusschen merged commit be355b0 into Hacker0x01:main Dec 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default style has changed in v9

2 participants