Skip to content

Add verification to time picker when shouldCloseOnSelect is false #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2018
Merged

Add verification to time picker when shouldCloseOnSelect is false #1529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,9 @@ export default class DatePicker extends React.Component {
});

this.props.onChange(changedDate);
this.setOpen(false);
if (this.props.shouldCloseOnSelect) {
this.setOpen(false);
}
this.setState({ inputValue: null });
};

Expand Down
12 changes: 12 additions & 0 deletions test/timepicker_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,18 @@ describe("TimePicker", () => {
expect(getInputString()).to.equal("February 28, 2018 4:43 PM");
});

it("should not close datepicker after time clicked when shouldCloseOnSelect is false", () => {
var datePicker = TestUtils.renderIntoDocument(
<DatePicker shouldCloseOnSelect={false} showTimeSelect />
);
var dateInput = datePicker.input;
TestUtils.Simulate.focus(ReactDOM.findDOMNode(dateInput));
const time = TestUtils.findRenderedComponentWithType(datePicker, Time);
const lis = TestUtils.scryRenderedDOMComponentsWithTag(time, "li");
TestUtils.Simulate.click(lis[0]);
expect(datePicker.state.open).to.be.true;
});

function setManually(string) {
TestUtils.Simulate.focus(datePicker.input);
TestUtils.Simulate.change(datePicker.input, { target: { value: string } });
Expand Down