Skip to content

Added nonfunctional profile picture edit and delete icons#265

Open
sirQuail wants to merge 3 commits intomainfrom
frontend/profile-picture-editor-buttons
Open

Added nonfunctional profile picture edit and delete icons#265
sirQuail wants to merge 3 commits intomainfrom
frontend/profile-picture-editor-buttons

Conversation

@sirQuail
Copy link
Contributor

Description

Adds nonfunctional edit and delete buttons only visible when hovering over a trainee profile picture.
Will be expanded to include confirmation and upload modals and finally api implementation.

Showcase

image

@HackYourFutures HackYourFutures temporarily deployed to dojo-frontend-profile-p-fcc4jt December 16, 2025 11:06 Inactive
@stasel stasel requested a review from Copilot December 16, 2025 11:10
width: 180,
}}
>
<Fade in={isHovering}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this can be made much simple with only a CSS hover rule? What is the added benefit of using Fade?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is also possible to do it via CSS, the benefit of using Fade is that it is a part of the MUI that we use.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds non-functional edit and delete icon buttons that appear when hovering over a trainee's profile picture. The implementation uses Material-UI components with fade animations and hover effects, setting the groundwork for future functionality including confirmation modals, upload dialogs, and API integration.

Key Changes:

  • Added hover state management using React useState to show/hide edit and delete icons
  • Implemented visual feedback with brightness filter on avatar and scale transforms on icons
  • Used Material-UI Fade component for smooth icon transitions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

spearated profile picture modal for better readablity
Copy link
Member

@stasel stasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants