- 
                Notifications
    You must be signed in to change notification settings 
- Fork 0
Adapt cabin sorting endpoints #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…om different databases
…en hydrating cabinscores, and more accurate types for function returns
| The latest updates on your projects. Learn more about Vercel for Git ↗︎ 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Fix merge conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove your name from the PR title if that's alright! just two small comments, looking good. thanks for moving fast on it!
| @@ -1,109 +1,46 @@ | |||
| { | |||
| "compilerOptions": { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason to include ALL of these settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I transferred the options over from judging algo but it does work without all of the included options so i reverted it to what I had with a few updates
| } | ||
|  | ||
| // let's get sorting!! | ||
| hackerSortingAlgo() | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't call this directly in the file, call within your main sorting process. similar callout to https://github.com/HackBeanpot/internal-tools/pull/137/files#diff-2b2de8166d35c5f271eae616c700b6841e5920da821789a78a1ac62963e760f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main sorting process is done in the hackerSortingAlgo.ts file, there is no main file that calls the script like in judging algo's index.ts for the parser function. For this one I would have to leave this function here I believe
Need to move on from this ticket. Has been approved by 2 members and made the requested changes
Hot fix for previous merge: