Skip to content

Conversation

@NelsonDong41
Copy link
Contributor

Hot fix for previous merge:

  • Functionality for remove all functions in judging algorithm daos were removed during merge. Reimplemented here

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 2:36am

Copy link
Contributor

@mike10911 mike10911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Fix merge conflicts

Copy link
Contributor

@surbhi-gulati surbhi-gulati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove your name from the PR title if that's alright! just two small comments, looking good. thanks for moving fast on it!

@@ -1,109 +1,46 @@
{
"compilerOptions": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason to include ALL of these settings?

Copy link
Contributor Author

@NelsonDong41 NelsonDong41 Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I transferred the options over from judging algo but it does work without all of the included options so i reverted it to what I had with a few updates

}

// let's get sorting!!
hackerSortingAlgo()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't call this directly in the file, call within your main sorting process. similar callout to https://github.com/HackBeanpot/internal-tools/pull/137/files#diff-2b2de8166d35c5f271eae616c700b6841e5920da821789a78a1ac62963e760f3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main sorting process is done in the hackerSortingAlgo.ts file, there is no main file that calls the script like in judging algo's index.ts for the parser function. For this one I would have to leave this function here I believe

@NelsonDong41 NelsonDong41 changed the title Nelson adapt cabin sorting endpoints Adapt cabin sorting endpoints Jul 20, 2023
@NelsonDong41 NelsonDong41 dismissed surbhi-gulati’s stale review July 22, 2023 00:21

Need to move on from this ticket. Has been approved by 2 members and made the requested changes

@NelsonDong41 NelsonDong41 merged commit 02941c2 into main Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants