Skip to content

Fix: Select class modal now shows base items #15335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 28, 2024
Merged

Fix: Select class modal now shows base items #15335

merged 6 commits into from
Oct 28, 2024
+23 −45

Conversation

CuriousMagpie
Copy link
Contributor

@CuriousMagpie CuriousMagpie commented Oct 4, 2024 •
edited
Loading

Changes:

  • Each class avatar now shows the class's best "basic" gear instead of Gala gear
  • Avatars have been slightly nudged so they're all more or less centered and no longer move when you select one
  • Updated CSS selectors to px from em where appropriate (margins, padding)

Tressley
Tressley reviewed Oct 21, 2024
View reviewed changes
Tressley
Tressley reviewed Oct 22, 2024
View reviewed changes
@CuriousMagpie CuriousMagpie marked this pull request as ready for review October 22, 2024 15:37
SabreCat
SabreCat requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@SabreCat SabreCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, one suggestion, easy to resolve!

website/client/src/components/achievements/chooseClass.vue Outdated
}

.danger {
color: $red-50;
margin-bottom: 0em;
margin-bottom: 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anywhere you're setting a margin-bottom: 0; you can use the mb-0 helper class in the html, will save you some CSS lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@SabreCat SabreCat merged commit 3d68983 into HabitRPG:develop Oct 28, 2024
10 checks passed
@CuriousMagpie CuriousMagpie deleted the class-selection branch February 14, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tressley Tressley Tressley left review comments

@SabreCat SabreCat SabreCat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CuriousMagpie @Tressley @SabreCat