V1 - dont look for bucket we know don't exists #1606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adobrzyn
requested review from
kzawora-intel,
madamczyk-intel,
michalkuligowski,
mgawarkiewicz-intel,
vivekgoe,
afierka-intel,
xuechendi,
jikunshang,
mswiniarsk and
PatrykWo
as code owners
|
/run-gaudi-tests |
madamczyk-intel
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an early exit in the 2D prompt bucketing logic when the batch size exceeds the maximum allowed, and updates the merge check to handle the new sentinel return values.
- Added a pre-check in
_bucketize_2d_promptto return(None, None, None)for oversized batches. - Updated
_can_merge_prefill_contentsto treat anyNonein the bucketing result as a non-mergeable case.
Comments suppressed due to low confidence (2)
vllm/v1/worker/hpu_model_runner.py:969
- [nitpick] Consider renaming the variable
bstobatch_sizefor improved readability and to make its purpose immediately clear.
if bs > self.max_prefill_batch_size:
vllm/v1/worker/hpu_model_runner.py:969
- Add a unit test to verify that
_bucketize_2d_promptreturns(None, None, None)when the batch size exceedsmax_prefill_batch_size, ensuring this new branch is covered.
if bs > self.max_prefill_batch_size:
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
|
/run-gaudi-tests |
adobrzyn
added a commit
that referenced
this pull request
Jul 16, 2025
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
madamczyk-intel
pushed a commit
that referenced
this pull request
Jul 17, 2025
kzawora-intel
added a commit
to vllm-project/vllm-gaudi
that referenced
this pull request
Jul 17, 2025
ripped from: HabanaAI/vllm-fork#1606, fixes weird bucketing anomaly where bs=1 prefills would be padded to bs=2 and trigger a recompilation Signed-off-by: Konrad Zawora <kzawora@habana.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.