Update Force Channel FP8 Check #1561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yiliu30 <yi4.liu@intel.com>
yiliu30
requested review from
kzawora-intel,
madamczyk-intel,
michalkuligowski,
mgawarkiewicz-intel,
vivekgoe,
afierka-intel,
xuechendi,
jikunshang,
mswiniarsk and
PatrykWo
as code owners
This was referenced Jul 10, 2025
czhu15
reviewed
Jul 10, 2025
mfylcek
approved these changes
Jul 10, 2025
xuechendi
approved these changes
Jul 10, 2025
|
/run-gaudi-tests |
michalkuligowski
pushed a commit
that referenced
this pull request
Jul 15, 2025
Porting #1561 Signed-off-by: yiliu30 <yi4.liu@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with 1.22, INC also supports dynamic quantization. To make things smoother for users, and after discussing with @xuechendi , we plan to update how we handle the force channel fp8 check:
QUANT_CONFIG, we assume the intention is to use INC for either dynamic or static quantization.QUANT_CONFIGis provided but the user passes an FP8 model, the workflow defaults to the built-in dynamic quantization path w/o INC.cc @thuang6 @czhu15 @yangulei