Dev/talco/hbl next vs after fix #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For upstream purposes and to have more robust code, a common cfg lock function shall be created. The function shall invoke the asic port's specific function. Signed-off-by: Tal Cohen <tal5.cohen@intel.com>
Replace the port's cfg lock from port specific into port's common code. This change is further to the common cfg lock function change. Signed-off-by: Tal Cohen <tal5.cohen@intel.com>
andreyagranovich
suggested changes
Mar 11, 2025
| @@ -1171,6 +1171,8 @@ struct hbl_cn_port { | |||
| struct mutex control_lock; | |||
| /* protects the counters from concurrent reading */ | |||
| struct mutex cnt_lock; | |||
| /* Serializes the port configuration */ | |||
There was a problem hiding this comment.
Why comment is here and not in the documentation for the struct above?
Comment on lines
4762
to
+4764
| mutex_destroy(&cn_port->cnt_lock); | ||
| mutex_destroy(&cn_port->control_lock); | ||
| mutex_destroy(&cn_port->cfg_lock); |
There was a problem hiding this comment.
Suggested change
| mutex_destroy(&cn_port->cnt_lock); | |
| mutex_destroy(&cn_port->control_lock); | |
| mutex_destroy(&cn_port->cfg_lock); | |
| mutex_destroy(&cn_port->cfg_lock); | |
| mutex_destroy(&cn_port->cnt_lock); | |
| mutex_destroy(&cn_port->control_lock); |
andreyagranovich
suggested changes
Mar 11, 2025
| @@ -332,8 +332,6 @@ struct gaudi2_cn_port { | |||
| struct delayed_work eq_work; | |||
| struct delayed_work qp_sanity_work; | |||
| struct workqueue_struct *qp_sanity_wq; | |||
| /* Serializes the port configuration */ | |||
| struct mutex cfg_lock; | |||
There was a problem hiding this comment.
Please also delete the documetnation of this field above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.