-
-
Notifications
You must be signed in to change notification settings - Fork 207
Edits for Jamstack 2021 Chapter #2634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I reviewed the content, but left the grammar and figure descriptions for the editing phase. |
Great! Sometimes I feel like if I change the grammar without understanding the content it can change the meaning. I think I left at least one TODO of something that needs grammar tweaking but didn’t know how to fix it |
src/content/en/2021/jamstack.md
Outdated
| The number of sites in Europe for desktop is 23k versus mobile 26k, which is 1.1% of all web sites in that region. In the Americas, there are 26k desktop sites and 24k mobiles sites (1.2% of sites). Asia has almost the same numbers with 21k desktop and 22k mobile as the leading region with greater Jamstack adoption at 1.45%. Oceania and Africa have way lower overall numbers, but they have way greater Jamstack adoption. Oceania 2.19% and Africa 2%. Overall site adoption is at 1.1%. | ||
|
|
||
| Oceania and Africa have way lower overall numbers, but they have way greater Jamstack adoption. Oceania 2.19% and Africa 2%. | ||
| {# TODO - do you need to list the numbers for each, or should percentages be enough? or numbers for just the first as a baseline #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally try to avoid absolute numbers and prefer percentages. The make no sense without context of how many they are out of.
However sometimes they can be useful to set context - particularly for small numbers (e.g. "it's only 0.1% but in the context of the web that's still a massive number of 600,000 sites"). But that should be the exception and not over used.
tunetheweb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some suggestions here for visibility. However I'm going to merge these right away as running out of time here.
|
I've added some better descriptions but not all. I'm going to merge this as think these edits are good. Leaving TODOs in place for better descriptions. |
|
@shantsis thanks for the edits 🚀 |
Progress on #2525
Closes #2156
Stage link: https://20211116t174953-dot-webalmanac.uk.r.appspot.com/en/2021/jamstack
Basic edits and some TODOs for the authors to review. I don't know this content at all so another editor should review this all well