-
-
Notifications
You must be signed in to change notification settings - Fork 207
Edits for WebAssembly 2021 Chapter #2605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@RReverser see my comments above on the chart labels :) |
The Web Almanac style is currently the green as discussed previously. We recognise the colour contrast issues but we have not come up with a better solution this year. The black colour as an outside label on charts with both green and grey datasets looks poor and is confusing and puts more focus on the green data set when grey (mobile) is primary. We see the data labels as supplementary information (that are often dropped showing they are not "needed" and nice to haves), and supplement them with meaningful descriptions. This is the direction we have decided to go for this year. |
Is the solution to just drop the green labels, or am I mis interpreting it? |
We use them sparingly and when they are the only labels we change label colour to the grey like in figure 17 for example. Where they do fit without looking squashed, we do allow them to be displayed rather than dropping for the sake of dropping as they are supplemental data and there are multiple other ways of getting the same information (using the scale, comparing relative to the grey numbers, hovering on them, or using the descriptions). The green bar itself is too light as well but we don't drop that. |
Oh right, sorry for the confusion 😅 |
|
Left some comments / questions / clarifications, the rest looks good, thanks! |
tunetheweb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I think this is good to merge. One more FYI for you @RReverser
Progress on #2525
Closes #2168
Stage link: https://20211116t174953-dot-webalmanac.uk.r.appspot.com/en/2021/webassembly
Basic edits and some TODOs for the author to review