Skip to content

Conversation

@shantsis
Copy link
Contributor

Progress on #2525
Closes #2168

Stage link: https://20211116t174953-dot-webalmanac.uk.r.appspot.com/en/2021/webassembly

Basic edits and some TODOs for the author to review

  • Also a lot of the charts use light green labels, which need to be removed or replaced with black

@shantsis shantsis added the editing Content excellence label Nov 29, 2021
@shantsis shantsis added this to the 2021 Launch 🚀 milestone Nov 29, 2021
@shantsis
Copy link
Contributor Author

@RReverser see my comments above on the chart labels :)

@tunetheweb
Copy link
Member

https://20211116t174953-dot-webalmanac.uk.r.appspot.com/en/2021/webassembly

The Web Almanac style is currently the green as discussed previously. We recognise the colour contrast issues but we have not come up with a better solution this year. The black colour as an outside label on charts with both green and grey datasets looks poor and is confusing and puts more focus on the green data set when grey (mobile) is primary. We see the data labels as supplementary information (that are often dropped showing they are not "needed" and nice to haves), and supplement them with meaningful descriptions. This is the direction we have decided to go for this year.

@shantsis
Copy link
Contributor Author

https://20211116t174953-dot-webalmanac.uk.r.appspot.com/en/2021/webassembly

The Web Almanac style is currently the green as discussed previously. We recognise the colour contrast issues but we have not come up with a better solution this year. The black colour as an outside label on charts with both green and grey datasets looks poor and is confusing and puts more focus on the green data set when grey (mobile) is primary. We see the data labels as supplementary information (that are often dropped showing they are not "needed" and nice to haves), and supplement them with meaningful descriptions. This is the direction we have decided to go for this year.

Is the solution to just drop the green labels, or am I mis interpreting it?

@tunetheweb
Copy link
Member

Is the solution to just drop the green labels, or am I mis interpreting it?

We use them sparingly and when they are the only labels we change label colour to the grey like in figure 17 for example. Where they do fit without looking squashed, we do allow them to be displayed rather than dropping for the sake of dropping as they are supplemental data and there are multiple other ways of getting the same information (using the scale, comparing relative to the grey numbers, hovering on them, or using the descriptions). The green bar itself is too light as well but we don't drop that.

@shantsis
Copy link
Contributor Author

Is the solution to just drop the green labels, or am I mis interpreting it?

We use them sparingly and when they are the only labels we change label colour to the grey like in figure 17 for example. Where they do fit without looking squashed, we do allow them to be displayed rather than dropping for the sake of dropping as they are supplemental data and there are multiple other ways of getting the same information (using the scale, comparing relative to the grey numbers, hovering on them, or using the descriptions). The green bar itself is too light as well but we don't drop that.

Oh right, sorry for the confusion 😅

@RReverser
Copy link
Member

Left some comments / questions / clarifications, the rest looks good, thanks!

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I think this is good to merge. One more FYI for you @RReverser

@tunetheweb tunetheweb merged commit 1f5aca9 into main Nov 29, 2021
@tunetheweb tunetheweb deleted the web-assembly-edits branch November 29, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editing Content excellence

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebAssembly 2021

4 participants