Skip to content

Conversation

@shantsis
Copy link
Contributor

@shantsis shantsis commented Nov 17, 2021

Progress on #2525
Closes #2151

Stage link: https://20211119t010018-dot-webalmanac.uk.r.appspot.com/en/2021/mobile-web

@ashleyish you're also missing your bio. I tagged you in a couple spots, including most of the figure descriptions because they don't describe the actual stats

@shantsis shantsis added the editing Content excellence label Nov 17, 2021
@shantsis shantsis added this to the 2021 Launch 🚀 milestone Nov 17, 2021
@shantsis
Copy link
Contributor Author

shantsis commented Nov 17, 2021

@tunetheweb / @rviscomi this chapter has 2 GIFs for images which are great (they convey the message), but they also make me wonder if we need a mechanism to stop or pause them for accessibility. https://www.w3.org/WAI/WCAG21/Understanding/pause-stop-hide

Edit: figures 12.26 and 12.27

@rviscomi
Copy link
Member

It'd be nice to support prefers-reduced-motion and use a still image instead. The first part of that is a task for developers and the second half would require asking the authors for a still version of the gif. WDYT?

@shantsis
Copy link
Contributor Author

I was thinking that too. In this case I'm not sure how the static message would show the delay they're exampling, but it could still work.
Is it possible to play the gif once or twice and then pause it the way MS teams does?

@tunetheweb
Copy link
Member

For the GIF issue, there's interesting tips here: https://css-tricks.com/gifs-and-prefers-reduced-motion/

To demonstrate the motion without the gif, you can just have two images side by side (like I did here:

image

We'll probably need something like this for the ebook anyway.

@shantsis
Copy link
Contributor Author

For the GIF issue, there's interesting tips here: https://css-tricks.com/gifs-and-prefers-reduced-motion/

To demonstrate the motion without the gif, you can just have two images side by side (like I did here:

image

We'll probably need something like this for the ebook anyway.

I like it! Long as we give that guidance to the authors it shouldn't be too hard to do. And good point for the ebook.

@dwsmart
Copy link
Contributor

dwsmart commented Nov 18, 2021

For the GIF issue, there's interesting tips here: https://css-tricks.com/gifs-and-prefers-reduced-motion/
To demonstrate the motion without the gif, you can just have two images side by side (like I did here:
image
We'll probably need something like this for the ebook anyway.

I like it! Long as we give that guidance to the authors it shouldn't be too hard to do. And good point for the ebook.

Happy to do that, should we just have a side by side anyway? I liked the animation, but sounds like it may be an issue?

@tunetheweb
Copy link
Member

We’ll figure out a way of making both work. Always interesting to think about these things and add the abilities to our toolkit for future years!

Could you come up with the side by side image though and add to this branch? The. Leave the rest to me.

@dwsmart
Copy link
Contributor

dwsmart commented Nov 18, 2021

Absolutely, will do this later! will the gif and the static need to be the same dimensions?

@tunetheweb
Copy link
Member

Nah. As presume the side by side one will be wider.

@dwsmart
Copy link
Contributor

dwsmart commented Nov 18, 2021

added desktop-cls-example-static.png & mobile-cls-example-static.png

@dwsmart
Copy link
Contributor

dwsmart commented Nov 18, 2021

I addressed some of the great, valid points @shantsis, in the last commit I added a {# TODO (Editor) - … #} comment under yours for clarity, hope that's not breaking anything.

fellowhuman1101 and others added 6 commits November 18, 2021 10:06
Added bio for @ashleyish; updated chart descriptions for
- Device type distribution by day - mPulse July 2021
- Percentage of Sites with more Mobile than Desktop Traffic
Added definition list markdown to device client hints.
Updated chart description for
- client device hints
- Network Information API
- Device memory API
Updated chart descriptions for
- ARIA Roles
- Color Contrast
- Zooming and scaling
-LCP
-Responsive Images
-Lazy loading
@tunetheweb
Copy link
Member

Fixed the Gif thing. Can't get it to stop after two run throughs but do handle prefers-reduced-motion and ebook.

As mentioned in the chat:

I’ve just made another run through, more on the technical and “Web Almanac” consistency side and made quite a few edits (hope you don’t mind - but let me know if you massively disagree with any of them!).

Unfortunately, I’ve raised a few more TODOs that I’d like you to look at. Sorry about that! Have a search for them, and feel free to remove them when addressed, rather than adding another “Editor: done” line. I trust cha!

I’ve staged the latest version here: https://20211119t010018-dot-webalmanac.uk.r.appspot.com/en/2021/mobile-web

I’d like another run through of the graphs, and need to redo some of the screenshots after that, but it’s late here now so will leave that until tomorrow or the weekend.

It’s definitely almost there. Great read!

@tunetheweb
Copy link
Member

Made some more edits for decimal place consistency, to add a couple more charts, increased the figure descriptions and run another spelling and grammar check.

I think this is good to merge.

@fellowhuman1101 / @dwsmart are you finished or still planning on tweaking it further? If not let's get this merged and finished!!

@dwsmart
Copy link
Contributor

dwsmart commented Nov 26, 2021

Hey @tunetheweb, we're good here too, and happy for it to be merged!

@tunetheweb tunetheweb merged commit f5a6460 into main Nov 26, 2021
@tunetheweb tunetheweb deleted the mobile-web-edits branch November 26, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editing Content excellence

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile Web 2021

7 participants