Skip to content

Conversation

@tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Nov 29, 2020

to avoid duplication of code.

Follow on from #1574

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Nov 29, 2020
@tunetheweb tunetheweb added this to the 2020 Platform Development milestone Nov 29, 2020
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the process for generating Rainbow-specific markup? Should it be documented in a wiki?

@tunetheweb
Copy link
Member Author

What's the process for generating Rainbow-specific markup? Should it be documented in a wiki?

Was the last process? 😉

Was thinking about writing a specific function for Methodology page, but after I discovered how easy it was I figured that was overkill. What about commenting the code like I just added in the last commit?: 3fc4d42

@rviscomi
Copy link
Member

SGTM. The wasn't a process last time, it was manual!

@tunetheweb tunetheweb merged commit 28297cc into main Nov 30, 2020
@tunetheweb tunetheweb deleted the methodology_sql_syntax_highlighting branch November 30, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Building the Almanac tech stack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants