Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable ie #666

Merged
merged 1 commit into from
Jun 1, 2016
Merged

disable ie #666

merged 1 commit into from
Jun 1, 2016

Conversation

samuliheljo
Copy link
Contributor

The PR is done - it:

  • follows the style and naming rules (passes npm run lint)
  • doesn't break anything (passes npm run test-local and npm run test-browserstack)
  • design is as expected. NOTE! visuals are compared using HSL theme (CONFIG=hsl npm run dev).
    -- If no design changes: BS_USERNAME=user BS_ACCESS_KEY=key npm run test-visual passes
    -- If design changes: BS_USERNAME=user BS_ACCESS_KEY=key npm run test-visual-update to generate new images
  • any changed files are transformed to ES6
  • all changed components
    • have examples
    • have unit tests
    • are included in the style guide
    • are included in the visual tests (added to gemini tests)

If this PR fixes a bug, it includes a new test that catches the bug to prevent regressions.

@hannesj hannesj merged commit 89696a8 into master Jun 1, 2016
@samuliheljo samuliheljo deleted the disable-ie-tests branch June 2, 2016 13:23
vesameskanen added a commit that referenced this pull request Oct 3, 2024
DT-6453 Change map line color for external ferries to #666.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants