Skip to content

Conversation

@hjvuor
Copy link
Contributor

@hjvuor hjvuor commented Dec 12, 2025

Proposed Changes

  • implements DTAutosuggest using downshift.js

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in an issue in Azure Boards
  • Merge the pull request

@hjvuor hjvuor marked this pull request as draft December 12, 2025 13:19
@hjvuor hjvuor changed the title DRAFT: Autosuggest implementation using downshift AB#278 Autosuggest implementation using downshift Dec 30, 2025
@hjvuor hjvuor marked this pull request as ready for review December 30, 2025 11:43
@partisaani
Copy link
Contributor

partisaani commented Jan 7, 2026

image

Z-index needs to be bumped up a bit so that the suggestion box is rendered on top of the little rectangle blip

@Antiik91
Copy link
Member

Antiik91 commented Jan 8, 2026

Test comment

getInputProps({}, { suppressRefError: true });
getItemProps({ index: -1 }, { suppressRefError: true });

const isOriginDestinationOrViapoint =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This same variable is in utils file as well, exportable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants