Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for new speedtram type DT-5987 + DT-5988 + DT-5989 #4840

Merged
merged 9 commits into from
Aug 23, 2023
Merged

feat: support for new speedtram type DT-5987 + DT-5988 + DT-5989 #4840

merged 9 commits into from
Aug 23, 2023

Conversation

tekoiv
Copy link
Contributor

@tekoiv tekoiv commented Jul 11, 2023

Proposed Changes

  • Add themes and icons
  • Placeholder info box for route type 902
  • Update digitransit-packages

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

optionsome
optionsome reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@optionsome optionsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stop icons in search and also on map where a speed tram went through have wrong color and icon. In an itinerary view, the tram leg has wrong color on the left side of the details.

digitransit-component/packages/digitransit-component-suggestion-item/src/index.js Outdated
@@ -152,6 +155,14 @@ function getIconProperties(
'TRAM-digitransit',
{ icon: 'search-tram-stop-digitransit', color: 'mode-tram' },
],
[
'SPEEDTRAM-default',
{ icon: 'search-speedtram-stop-digitransit', color: 'mode-tram' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have custom color?

digitransit-component/packages/digitransit-component-suggestion-item/src/index.js Outdated
@@ -8,13 +8,16 @@ import styles from './helpers/styles.scss';

const BUS_EXPRESS = 702;
const BUS_LOCAL = 704;
const SPEEDTRAM = 902;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should call this TRAM_LOCAL in code instead of SPEEDTRAM as the spelling is more inline with the BUS_LOCAL and the 902 route type refers to Local Tram Service (even though in our context it means "pikaratikka").

@optionsome optionsome merged commit af057cb into v3 Aug 23, 2023
5 checks passed
@optionsome optionsome deleted the DT-5987 branch August 23, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optionsome optionsome optionsome left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tekoiv @optionsome @vesameskanen