Replace os.system with subprocess.run
#65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 8, 2023 15:58
Besides being recommended by the Python documentation of `os.system()` itself (https://docs.python.org/3/library/os.html#os.system), the previous implementation with `os.system()` has the issue of not handling paths with spaces, since the arguments like `program_path` and `object_path` were concatenated as strings and then incorrectly parsed by GCC in the presence of whitespace. With `subprocess.run()`, we provide a list of arguments and the paths are handled correctly. A small commented piece of code has been introduced to build up an arguments list correctly.
This is relative to the previous commit, and fixes the code in some instances where the `args` list ended up with empty arguments or arguments with trailing spaces.
gdelazzari
force-pushed
the
feature-subprocess.run
branch
from
41ed506 to
94f4002
Compare
jaimesouza
approved these changes
May 9, 2023
Collaborator
jaimesouza
left a comment
jaimesouza
left a comment
There was a problem hiding this comment.
Thanks for your contribution @gdelazzari
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides being recommended by the Python documentation of
os.system()itself (https://docs.python.org/3/library/os.html#os.system), the previous implementation withos.system()has the issue of not handling paths with spaces, since the arguments likeprogram_pathandobject_pathwere concatenated as strings and then incorrectly parsed by GCC in the presence of whitespace.With
subprocess.run(), we provide a list of arguments and the paths are handled correctly. A small commented piece of code has been introduced to build up an arguments list correctly.