Baseline alignment #169
Closed
Baseline alignment #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, I seem to have made a mistake with the ifdef, but I guess the idea is to upgrade the deps anyway :) |
This implements set_baseline_tag_range and set_baseline_shift. The former can be used to align a glyph with a given opentype baseline, while the latter can be used to shift the baseline.
therahedwig
force-pushed
the
baseline-alignment
branch
from
11813c8 to
464d231
Compare
This was referenced May 2, 2022
Merged
Merged
|
After much consideration, it really seems CSS-baseline alignment is tree-wise, which Raqm knows nothing about. I had to implement this separately in my textlayout code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements set_baseline_tag_range and set_baseline_shift. This patch is build on top of #165 .
The former can use opentype tags like "romn" and "hang", while the latter uses FreeType Font Units, and both values get added to the offset, depending on the direction.
I am not sure if offset is the correct place to add these values, as perhaps that makes it harder to align the caret properly.
Similarly, I am wondering about whether specific baseline-shift for super and sub are still useful here, or whether I should calculate these myself (given they need a font different than the current one to be correct).
Fix #167