Fix Workflow failing

.github/PULL_REQUEST_TEMPLATE.md

@@ -5,10 +5,10 @@
 - [ ] **This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.**
 Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. Thank you for your understanding.
 -----
-<!-- optionally, explain here about the committed code -->
 
+<!-- optionally, explain here about the committed code -->
 -----
-<!-- insert below the issue number (if applicable) -->
+<!-- insert below the issue number (if applicable, do not create a new issue to justify a PR) -->
 Closes #XXXX
-<!-- or -->
+<!-- and/or -->
 Relates to #XXXX

.github/workflows/dotnet-test.yml

@@ -1,19 +1,24 @@
 name: .NET Tests
 on:
   push:
+    branches: [ "main" ]
     paths:
       - '**.cs'
       - '**.csproj'
+      - '**.sln'
+
   pull_request:
     branches: [ "main" ]
     paths:
       - '**.cs'
       - '**.csproj'
+      - '**.sln'
+
   workflow_dispatch:
 
 jobs:
 
-  test:
+  test-codebase:
     runs-on: windows-latest  # For a list of available runner types, refer to
                              # https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idruns-on
 

.github/workflows/translations-test.yml

@@ -2,23 +2,29 @@ name: Translation integrity
 on:
   pull_request:
     branches: [ "main" ]
-    paths:
-      - '**.json'
+
   workflow_dispatch:
 
 jobs:
-
-  test:
-    if: github.event.
+  test-translations-and-approve:
+    if: contains(github.event.pull_request.labels.*.name, 'tolgee-ci')
     runs-on: ubuntu-latest  # For a list of available runner types, refer to
                              # https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idruns-on
 
     steps:
     - name: Checkout the repository
+      id: checkout
       uses: actions/checkout@v4
       with:
         fetch-depth: 0
 
     - name: Test translations
+      id: tests
       run: |
         python scripts/verify_translations.py
+
+    - name: Approve PR since checks are Ok
+      uses: hmarr/auto-approve-action@v4
+      with:
+        review-message: "Tolgee-CI Changes have been approved since they passed testing"
+

.github/workflows/update-icons.yaml

@@ -5,7 +5,7 @@ on:
     - cron: 0 0 * * *
   workflow_dispatch:
 jobs:
-  main:
+  load-icons:
     runs-on: windows-latest
     steps:
       - name: Checkout repository

.github/workflows/update-tolgee.yml

@@ -5,8 +5,10 @@ on:
     - cron: 0 0 * * *
   workflow_dispatch:
 jobs:
-  main:
+  load-translations:
+    if: github.repository == 'marticliment/UniGetUI'
     runs-on: ubuntu-latest
+
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -27,7 +29,6 @@ jobs:
           labels: tolgee-ci
           title: "Load translations from Tolgee"
           body: ""
-          # reviewers: "${{ github.repository_owner }}"
           author: "Martí Climent <marticlilop@gmail.com>"
           commit-message: "Load updated translations from Tolgee"
           branch: pull-request/update-translation

CONTRIBUTING.md

@@ -1,5 +1,5 @@
 -------------------------------------------------------------
-This repository **respects** people, despite their race, gender, religion, height, or culture. Any user who posts offensive or disrespectful content regarding race, gender, religion, height, or culture **will be immediately banned from this repository**. No exception will be made.
+This repository **respects** people, regardless of their race, gender, religion, height, or culture. Any user who posts offensive or disrespectful content regarding race, gender, religion, height, or culture **will be immediately banned from this repository**. No exception will be made.
 
 -------------------------------------------------------------
 
@@ -22,14 +22,14 @@ Before reading: All of the rules below are guidelines, which means that they sho
  - Please use the BUG/ISSUE template
  - Please be clear when describing issues.
  - Please fill out the form and DO NOT send empty issues with the information on the title.
- - Please make sure to check for duplicates as said in the BUG/ISSUE template.
+ - Please search for possible duplicates, and only post new content. (As stated in the BIG/ISSUE template).
  - Please make sure to preceed titles with the `[BUG/ISSUE]` string, so they can be easily identified.
 
 #### Feature requests:
 - Please use the FEATURE REQUEST template
  - Please detail how the feature should work. Please be as specific as possible.
  - Some features are difficult and might take some time to get implemented. This project is made in the contributor's free time, so please do not post messages asking for ETAs or similar. Every feature request will be considered.
- - Please make sure to check for duplicates as said in the FEATURE REQUEST template.
+ - Please check for duplicates as said in the FEATURE REQUEST template.
  - Please make sure to preceed titles with the `[FEATURE REQUEST]` string, so they can be easily identified.
 
 ## Pull requests:

README.md

@@ -16,6 +16,12 @@ Check out the [Supported Package Managers Table](#supported-package-managers) fo
 ![Endpoint Badge](https://img.shields.io/endpoint?url=https%3A%2F%2Fmarticliment.com%2Fresources%2Fbadges%2Fdev-status.json)
 ![GitHub Actions Workflow Status](https://img.shields.io/github/actions/workflow/status/marticliment/WingetUI/dotnet-test.yml?branch=main&style=for-the-badge&label=Tests)
 
+
+## Support the developer
+
+It really does make a big difference, and is very much appreciated. Thanks :)<br>
+[![ko-fi](https://ko-fi.com/img/githubbutton_sm.svg)](https://ko-fi.com/P5P86KKPB)
+
 ## Table of contents
  - **[UniGetUI Homepage](https://www.marticliment.com/unigetui/)**
  - [Table of contents](#table-of-contents)
@@ -61,13 +67,6 @@ choco install wingetui
 UniGetUI has a built-in autoupdater. However, it can also be updated like any other package within UniGetUI (since UniGetUI is available through Winget and Scoop).
 
 
-## Support the developer
-
-It really does make a big difference, and is very much appreciated. Thanks :)
-
-<a href='https://ko-fi.com/martinet101' target='_blank'><img style='border:0px;height:36px;' src='https://az743702.vo.msecnd.net/cdn/kofi3.png?v=0' border='0' alt='Buy Me a Coffee at ko-fi.com' /></a>
-
-
 ## Features
 
  - Install, update, and remove software from your system easily at one click: UniGetUI combines the packages from the most used package managers for windows: Winget, Chocolatey, Scoop, Pip, Npm and .NET Tool.
@@ -136,14 +135,14 @@ To translate UniGetUI to other languages or to update an old translation, please
 | <img src='https://flagcdn.com/id.svg' width=20> &nbsp; Indonesian - Bahasa Indonesia | 83% | [arthackrc](https://github.com/arthackrc), [joenior](https://github.com/joenior) |
 | <img src='https://flagcdn.com/jp.svg' width=20> &nbsp; Japanese - 日本語 | 94% | [nob-swik](https://github.com/nob-swik), sho9029, [tacostea](https://github.com/tacostea), Yuki Takase |
 | <img src='https://flagcdn.com/kr.svg' width=20> &nbsp; Korean - 한국어 | 85% | [minbert](https://github.com/minbert), [shblue21](https://github.com/shblue21), [VenusGirl](https://github.com/VenusGirl) |
-| <img src='https://flagcdn.com/lt.svg' width=20> &nbsp; Lithuanian - Lietuvių | 64% | [dziugas1959](https://github.com/dziugas1959) |
+| <img src='https://flagcdn.com/lt.svg' width=20> &nbsp; Lithuanian - Lietuvių | 74% | [dziugas1959](https://github.com/dziugas1959), Džiugas Januševičius |
 | <img src='https://flagcdn.com/mk.svg' width=20> &nbsp; Macedonian - Македонски | 63% | LordDeatHunter |
 | <img src='https://flagcdn.com/no.svg' width=20> &nbsp; Norwegian (bokmål) | 100% | [yrjarv](https://github.com/yrjarv) |
 | <img src='https://flagcdn.com/no.svg' width=20> &nbsp; Norwegian (nynorsk) | 100% | [yrjarv](https://github.com/yrjarv) |
 | <img src='https://flagcdn.com/nl.svg' width=20> &nbsp; Dutch - Nederlands | 100% | [abbydiode](https://github.com/abbydiode), [CateyeNL](https://github.com/CateyeNL), [Stephan-P](https://github.com/Stephan-P) |
 | <img src='https://flagcdn.com/pl.svg' width=20> &nbsp; Polish - Polski | 100% | [KamilZielinski](https://github.com/KamilZielinski), [kwiateusz](https://github.com/kwiateusz), [RegularGvy13](https://github.com/RegularGvy13), [ThePhaseless](https://github.com/ThePhaseless) |
 | <img src='https://flagcdn.com/br.svg' width=20> &nbsp; Portuguese (Brazil) | 100% | [maisondasilva](https://github.com/maisondasilva), [ppvnf](https://github.com/ppvnf), [Rodrigo-Matsuura](https://github.com/Rodrigo-Matsuura), [thiagojramos](https://github.com/thiagojramos), [wanderleihuttel](https://github.com/wanderleihuttel) |
-| <img src='https://flagcdn.com/pt.svg' width=20> &nbsp; Portuguese (Portugal) | 96% | [PoetaGA](https://github.com/PoetaGA), [Tiago_Ferreira](https://github.com/Tiago_Ferreira) |
+| <img src='https://flagcdn.com/pt.svg' width=20> &nbsp; Portuguese (Portugal) | 100% | [PoetaGA](https://github.com/PoetaGA), [Tiago_Ferreira](https://github.com/Tiago_Ferreira) |
 | <img src='https://flagcdn.com/ro.svg' width=20> &nbsp; Romanian - Română | 100% | [SilverGreen93](https://github.com/SilverGreen93), TZACANEL |
 | <img src='https://flagcdn.com/ru.svg' width=20> &nbsp; Russian - Русский | 99% | [bropines](https://github.com/bropines), [DvladikD](https://github.com/DvladikD), [flatron4eg](https://github.com/flatron4eg), [katrovsky](https://github.com/katrovsky), Sergey, sklart |
 | <img src='https://flagcdn.com/sk.svg' width=20> &nbsp; Slovak - Slovenčina | 12% | [Luk164](https://github.com/Luk164) |
@@ -161,7 +160,7 @@ To translate UniGetUI to other languages or to update an old translation, please
 | <img src='https://flagcdn.com/cn.svg' width=20> &nbsp; Simplified Chinese (China) | 100% | Aaron Liu, adfnekc, [arthurfsy2](https://github.com/arthurfsy2), [bai0012](https://github.com/bai0012), BUGP Association, ciaran, CnYeSheng, Cololi, [dongfengweixiao](https://github.com/dongfengweixiao), [FloatStream](https://github.com/FloatStream), [seanyu0](https://github.com/seanyu0), [Sigechaishijie(Albert Peng)](https://github.com/Sigechaishijie(Albert Peng)), [SpaceTimee](https://github.com/SpaceTimee), Yisme |
 | <img src='https://flagcdn.com/tw.svg' width=20> &nbsp; Traditional Chinese (Taiwan) | 95% | Aaron Liu, CnYeSheng, Cololi, [Henryliu880922](https://github.com/Henryliu880922), [yrctw](https://github.com/yrctw) |
 
-Last updated: Wed Jul 31 16:42:05 2024
+Last updated: Thu Aug  8 00:11:29 2024
 <!-- END Autogenerated translations -->
 
 
@@ -211,7 +210,7 @@ If this doesn't work, consider asking for help at [Winget's project page](https:
 
 A: This is a known limitation of Winget. 
 
-See more details on the issue https://github.com/microsoft/winget-cli/issues/2603.<br>
+For more details, see this issue: https://github.com/microsoft/winget-cli/issues/2603.<br>
 
 #
 
@@ -242,7 +241,7 @@ Since 3.1.0: `--uninstall-unigetui`: Attempts to unregister UniGetUI from the no
 Since 3.1.0: `--migrate-wingetui-to-unigetui`: Attempts to migrate WingetUI data folders and shortcuts to UniGetUI, and silently quits<br>
 
 ### Installer command-line parameters:
-The installer is inno-setup based, so it supports regular Inno Setup command-line parameters. Additionally, it also supports the following parameters:
+The installer is inno-setup based. It supports all Inno Setup command-line parameters as well as the following:
 <br>`/NoAutoStart`: Will not launch UniGetUI after installing it.
 <br> `/ALLUSERS`: Install UniGetUI for every user
 <br> `/CURRENTUSER`: Install UniGetUI for the current user only

UniGetUI.iss

@@ -179,9 +179,12 @@ end;
 
 function InitializeSetup: Boolean;
 begin
-  Dependency_AddVC2015To2022;
-  Dependency_AddWebView2;
-  Result := True;
+  try
+    Dependency_AddVC2015To2022;
+    Dependency_AddWebView2;
+    Result := True;
+  except
+  end;
 end;
 
 

scripts/verify_translations.py

@@ -24,7 +24,7 @@ def eprint(*args, **kwargs):
                 BASE, COMPARE = results[1],results[2]
 
                 for find in re.findall(r'{[a-zA-Z0-9]+}', BASE):
-                    if BASE.count(find) != COMPARE.count(find):
+                    if BASE.count(find) > COMPARE.count(find):
                         Correct = False
                         print(f"Faulting line on file {FILE}, missing key is {find} on translation \"{BASE}\", with translation {COMPARE}")
 

src/UniGetUI.Core.Data/Assets/Data/Contributors.list

@@ -28,6 +28,7 @@ adfnekc
 vedantmgoyal9
 dave-sc
 aaronliu0130
+tiagorangel2011
 tomasz1986
 vsilvar
 yrjarv
@@ -39,12 +40,13 @@ harleylara
 pomodori92
 redactedscribe
 victorelec14
-tiagorangel2011
 Satanarious
 Pandoriaantje
 reima
 headquarter8302
 MSDNicrosoft
+ImgBotApp
+eltociear
 HorridModz
 Schtenk
 Carterpersall

src/UniGetUI.Core.LanguageEngine/Assets/Data/TranslatedPercentages.json

@@ -12,11 +12,12 @@
   "hr": "57%",
   "id": "83%",
   "ja": "94%",
+  "kn": "0%",
   "ko": "85%",
-  "lt": "64%",
+  "lt": "74%",
   "mk": "63%",
-  "pt_PT": "96%",
   "ru": "99%",
+  "sa": "0%",
   "si": "8%",
   "sk": "12%",
   "sl": "95%",

src/UniGetUI.Core.LanguageEngine/Assets/Data/Translators.json

@@ -306,6 +306,7 @@
       "link": ""
     }
   ],
+  "kn": [],
   "ko": [
     {
       "name": "minbert",
@@ -324,6 +325,10 @@
     {
       "name": "dziugas1959",
       "link": "https://github.com/dziugas1959"
+    },
+    {
+      "name": "Džiugas Januševičius",
+      "link": ""
     }
   ],
   "mk": [
@@ -444,6 +449,7 @@
       "link": ""
     }
   ],
+  "sa": [],
   "si": [
     {
       "name": "SashikaSandeepa",

src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_ca.json

@@ -2,7 +2,7 @@
   "(Last checked: {0})" : "(Comprovat per darrer cop: {0})",
   "(Number {0} in the queue)" : "(Número {0} a la cua)",
   "0 0 0 Contributors, please add your names/usernames separated by comas (for credit purposes). DO NOT Translate this entry" : "@marticliment",
-  "0 packages found" : "Cap paquet trobat",
+  "0 packages found" : "No s'han trobat paquets",
   "0 updates found" : "No s'han trobat actualitzacions",
   "1 - Errors" : "1 - Errors",
   "1 day" : "1 dia",

src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fi.json

@@ -41,7 +41,7 @@
   "Allow parallel installs (NOT RECOMMENDED)" : "Salli rinnakkaiset asennukset (EI SUOSITELLA)",
   "Allow {pm} operations to be performed in parallel" : "Salli toimintojen {pm} suorittaminen rinnakkain",
   "Always elevate {pm} installations by default" : "Nosta aina {pm} asennusten oikeustasoa",
-  "Always run {pm} operations with administrator rights" : "Suorita aina (pm) operaatiot järjestelmävalvojan oikeuksilla.",
+  "Always run {pm} operations with administrator rights" : "Suorita aina {pm} operaatiot järjestelmävalvojan oikeuksilla.",
   "An error occurred" : "Tapahtui virhe",
   "An error occurred when adding the source: " : "Tapahtui virhe lisätessä lähdettä: ",
   "An error occurred when checking for updates: " : "Tapahtui virhe tarkistaessa päivityksiä:",
@@ -636,7 +636,7 @@
   "{0} installation" : "{0} asennus",
   "{0} installation options" : "{0} asennuksen vaihtoehdot",
   "{0} is being updated" : "{0} ollaan päivittämässä",
-  "{0} is being updated to version {1}" : "{0} päivitetty versioon {0}",
+  "{0} is being updated to version {1}" : "{0} päivitetty versioon {1}",
   "{0} is disabled" : null,
   "{0} minutes" : "{0} minuuttia",
   "{0} packages are being updated" : null,

src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_gu.json

@@ -30,7 +30,7 @@
   "Add packages or open an existing bundle" : "પેકેજોને ઉમેરો અથવા હાલનાં બંડલને ખોલો",
   "Add selection to bundle" : "બંડલમાં પસંદગી ઉમેરો",
   "Add source" : "સ્ત્રોત ઉમેરો",
-  "Adding source {source} to {manager}" : "{વ્યવસ્થાપકમાં} સ્ત્રોત {સ્ત્રોત} ઉમેરી રહ્યા છીએ",
+  "Adding source {source} to {manager}" : null,
   "Addition succeeded" : "ઉમેરો સફળ થયો",
   "Administrator privileges" : "સંચાલક વિશેષાધિકારો",
   "Administrator privileges preferences" : "સંચાલક વિશેષાધિકાર પસંદગીઓ",

src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_hi.json

@@ -396,7 +396,7 @@
   "Searching for packages..." : "\nपैकेज खोजे जा रहे हैं...",
   "Searching for updates..." : "अपडेट खोजे जा रहे हैं...",
   "Select" : null,
-  "Select \"{item}\" to add your custom bucket" : "अपनी कस्टम बकेट जोड़ने के लिए \"{आइटम}\" चुनें",
+  "Select \"{item}\" to add your custom bucket" : "अपनी कस्टम बकेट जोड़ने के लिए \"{item}\" चुनें",
   "Select a folder" : null,
   "Select all" : "सभी चुने",
   "Select all packages" : "सभी पैकेजों का चयन करें",

src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_hu.json

@@ -625,7 +625,7 @@
   "update(verb)" : "frissíteni",
   "updated" : "frissítve",
   "updating" : "frissítés",
-  "{0} Uninstallation" : "{} Eltávolítás",
+  "{0} Uninstallation" : "{0} Eltávolítás",
   "{0} aborted" : "{0} megszakítva",
   "{0} can be updated" : "{0} frissíthető",
   "{0} can be updated to version {1}" : "{0} frissíthető {1} verzióra.",

src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_it.json

@@ -455,7 +455,7 @@
   "The backup will NOT include any binary file nor any program's saved data." : "Il backup NON includerà alcun file binario né dati salvati del programma.",
   "The backup will be performed after login." : "Il backup verrà eseguito dopo l'accesso.",
   "The backup will include the complete list of the installed packages and their installation options. Ignored updates and skipped versions will also be saved." : "Il backup includerà l'elenco completo dei pacchetti installati e le relative opzioni di installazione. Verranno salvati anche gli aggiornamenti ignorati e le versioni saltate.",
-  "The checksum of the installer does not coincide with the expected value, and the authenticity of the installer can't be verified. If you trust the publisher, {0} the package again skipping the hash check." : "L'hash del programma di installazione non coincide con il valore atteso, quindi l'autenticità non può essere verificata. Se ti fidi dell'editore, riprova saltando il controllo dell'hash.",
+  "The checksum of the installer does not coincide with the expected value, and the authenticity of the installer can't be verified. If you trust the publisher, {0} the package again skipping the hash check." : "L'hash del programma di installazione non coincide con il valore atteso, quindi l'autenticità non può essere verificata. Se ti fidi dell'editore, {0} una altra volta saltando il controllo dell'hash.",
   "The classical package manager for windows. You'll find everything there. <br>Contains: <b>General Software</b>" : "Il classico gestore di pacchetti per Windows. Qui troverai di tutto. <br>Contiene: <b>software generico</b>",
   "The following packages are going to be exported to a JSON file. No user data or binaries are going to be saved." : "I seguenti pacchetti verranno esportati in un file JSON. Nessun dato utente o file binario verrà salvato.",
   "The following packages are going to be installed on your system." : "Verranno installati sul tuo sistema i seguenti pacchetti.",
@@ -626,11 +626,11 @@
   "updated" : "aggiornato",
   "updating" : "aggiornamento",
   "{0} Uninstallation" : "Disinstallazione di {0}",
-  "{0} aborted" : "Operazione annullata",
+  "{0} aborted" : "{0} annullata",
   "{0} can be updated" : "{0} può essere aggiornato",
   "{0} can be updated to version {1}" : "{0} può essere aggiornato alla versione {1}",
   "{0} days" : "{0} giorni",
-  "{0} failed" : "Operazione non riuscita",
+  "{0} failed" : "{0} non riuscita",
   "{0} homepage" : "{0} homepage",
   "{0} hours" : "{0} ore",
   "{0} installation" : "Installazione di {0}",
@@ -648,7 +648,7 @@
   "{0} update" : "Aggiornamento di {0}",
   "{0} updates are available" : "Sono disponibili {0} aggiornamenti",
   "{0} was {1} successfully!" : "{0} è stato {1} correttamente!",
-  "{0} {1} failed" : "L'operazione con {0} non è riuscita",
+  "{0} {1} failed" : "L' {1} con {0} non è riuscita",
   "{package} Installation" : "Installazione di {package}",
   "{package} Uninstall" : "Disinstallazione di {package}",
   "{package} Update" : "Aggiornamento di {package}",