-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make prefix optional, at the moment it always renders prefix #165
Open
shivanshuit914
wants to merge
1
commit into
HMPO:master
Choose a base branch
from
shivanshuit914:feature/prefix-optional
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivanshuit914
force-pushed
the
feature/prefix-optional
branch
from
March 5, 2024 13:56
9f8596d
to
3e4d0f1
Compare
shivanshuit914
changed the title
Feature/prefix optional
Make prefix optional, at the moment it always renders prefix
Mar 5, 2024
AmritSidhu
approved these changes
Mar 5, 2024
shivanshuit914
force-pushed
the
feature/prefix-optional
branch
2 times, most recently
from
March 5, 2024 14:19
b9f6393
to
dbb5694
Compare
AmritSidhu
approved these changes
Mar 5, 2024
I'd you specify null or undefined it shouldn't get rendered. If you specify a string, even if empty, it will still render that empty string as that is what you have asked the component to do |
shivanshuit914
force-pushed
the
feature/prefix-optional
branch
from
March 10, 2024 20:09
dbb5694
to
1772a0b
Compare
@HughePaul are you able to get this work merged in? |
AmritSidhu
approved these changes
Mar 21, 2024
AmritSidhu
added a commit
to govuk-one-login/ipv-cri-kbv-hmrc-front
that referenced
this pull request
Mar 22, 2024
We are temporarily downgrading hmpo-components We made a change in hmpo-components to add the prefix feild to the text inputs, however this change made it a required feild and therefore cant use the input field without a prefix There is a current PR HMPO/hmpo-components#165 to fix this issue which is awaiting merge from HMPO It was decided that for now and to unblock our tickets that we revert to an earlier version of hmpo-components and just use the plain text input field until the above PR gets merged.
This was referenced Mar 22, 2024
blakeyp
added a commit
to govuk-one-login/ipv-cri-kbv-hmrc-front
that referenced
this pull request
May 20, 2024
We’re still waiting for hmpo-components PR HMPO/hmpo-components#165 to be merged and released. In the meantime we should implement a workaround so that amount fields have the “£” prefix while non-amount fields don’t.
blakeyp
added a commit
to govuk-one-login/ipv-cri-kbv-hmrc-front
that referenced
this pull request
May 21, 2024
We’re still waiting for hmpo-components PR HMPO/hmpo-components#165 to be merged and released. In the meantime we should implement a workaround so that amount fields have the “£” prefix while non-amount fields don’t.
blakeyp
added a commit
to govuk-one-login/ipv-cri-kbv-hmrc-front
that referenced
this pull request
May 21, 2024
We’re still waiting for hmpo-components PR HMPO/hmpo-components#165 to be merged and released. In the meantime we should implement a workaround so that amount fields have the “£” prefix while non-amount fields don’t.
blakeyp
added a commit
to govuk-one-login/ipv-cri-kbv-hmrc-front
that referenced
this pull request
May 22, 2024
We’re still waiting for hmpo-components PR HMPO/hmpo-components#165 to be merged and released. In the meantime we should implement a workaround so that amount fields have the “£” prefix while non-amount fields don’t.
SamChatfield
force-pushed
the
master
branch
3 times, most recently
from
August 1, 2024 16:28
307e703
to
6403fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BecioProton @georgeeker
Make prefix optional, at the moment it always renders prefix.