在修改游戏版本时清除已选的模组加载器#6475
Conversation
CiiLu
commented
Jul 22, 2026
CiiLu
commented
- 由于游戏版本发生改变，已有的加载器必然不兼容
- 且此功能会带来其他问题，例如 [Bug] 自动安装页面的不兼容提示显示不全 #6455 这是怎么回事 #4689
- Fabric Loader 各 Minecraft 版本对应的版本号是一样的，但仍然显示不兼容，会让用户产生疑惑
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b42213d188
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (controller.getSettings().containsKey(libraryId)) { | ||
| library.versionProperty().set(new InstallerItem.InstalledState(getVersion(libraryId), false, false)); |
There was a problem hiding this comment.
When a user updates a modded instance to a different Minecraft version and leaves its old Forge/Fabric/etc. card unselected, this branch only renders that card as absent; it does not add a RemoveVersionAction. UpdateInstallerWizardProvider.finish will consequently process only the new game selection, leaving the old loader patch in the saved version. The prior compatibility guard prevented completing this incompatible combination, whereas this now permits an installation that retains a loader built for the previous game version.
Useful? React with 👍 / 👎.
|
感觉不如 #6455 (comment) 方案 在此PR之前 用户在更新了游戏本体后 加载器会明显提示不兼容 而此PR直接清除已有的加载器那么会导致提示不明显(直接没有提示 可以直接进行安装(而这往往会导致忽略了更新加载器这一操作) 而原来是如果没更新加载器就不允许安装) 进游戏后用户会发现啥有没有 在回到启动器查看 这很不健康 或者就是在添加个明显的提示 提醒用户更新游戏本体的操作会同步清除安装的加载器 使用户及时发现进行加载器的更新 而不是进入到游戏发现没模组 没模组加载器在退出来回到HMCL添加 |
3 participants
