feat:优化数据包管理功能 #4672
Open
feat:优化数据包管理功能 #4672
+499
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wulian233
reviewed
Oct 14, 2025
| .forEach(info -> info.setActive(false)); | ||
| } | ||
|
|
||
| void openDataPackFolder() { |
3gf8jv4dv
reviewed
Oct 21, 2025
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
|
修改了列表选择的逻辑：
2025-10-26.23-15-49.720p.mp4 |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the datapack management system with improved UI capabilities and cleaner code structure. The changes include restructuring the Datapack class, adding search and selection features to the UI, and improving the icon loading mechanism for datapacks.
- Refactored
Datapackclass to use streams and functional programming patterns - Added search functionality with regex support for filtering datapacks
- Implemented multi-select operations with shift-click support and improved toolbar states
- Added icon loading for datapacks with proper caching and async handling
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| HMCLCore/src/main/java/org/jackhuang/hmcl/mod/Datapack.java | Refactored datapack loading/installation logic using streams, renamed fields for clarity, and restructured Pack class with improved state management |
| HMCL/src/main/resources/assets/img/unknown_pack.png | Added default placeholder image for datapacks without icons |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DatapackListPageSkin.java | Added search bar, selection toolbar, icon loading with caching, and improved user interaction handling |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DatapackListPage.java | Integrated search predicate logic and added method to open datapack folder |
Comments suppressed due to low confidence (1)
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DatapackListPageSkin.java:1
- The inline comment explains why
selectRange()is used instead ofselectAll(), but this comment should be on line 129 where the method is called, not on line 128. This would make the rationale clearer for future maintainers.
/*
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DatapackListPageSkin.java
Show resolved
Hide resolved
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DatapackListPageSkin.java
Show resolved
Hide resolved
| if (lastShiftClickIndex.get() == -1) { | ||
| lastShiftClickIndex.set(currentIndex); | ||
| toggleSelect.accept(cell.getIndex()); | ||
| } else if (listView.getItems().size() >= lastShiftClickIndex.get() && !(lastShiftClickIndex.get() < -1)) { |
There was a problem hiding this comment.
The condition !(lastShiftClickIndex.get() < -1) is unnecessarily complex and confusing. This is equivalent to lastShiftClickIndex.get() >= -1, which should be simplified for better readability.
Suggested change
| } else if (listView.getItems().size() >= lastShiftClickIndex.get() && !(lastShiftClickIndex.get() < -1)) { | |
| } else if (listView.getItems().size() >= lastShiftClickIndex.get() && lastShiftClickIndex.get() >= -1) { |
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DatapackListPage.java
Outdated
Show resolved
Hide resolved
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DatapackListPageSkin.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4661
重构Datapack类
工具栏在不同操作时改变内容
数据包搜索
显示数据包图标