Fix #4207: 网络整合包下载失败没有窗口提示 #4218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CiiLu
commented
Aug 7, 2025
CiiLu
commented
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #4207 by adding error dialogs for modpack download failures. The changes ensure that when network-based modpack downloads fail, users receive proper visual feedback through error dialog windows instead of silent failures.
- Added error logging and user-facing error dialogs for modpack download failures
- Enhanced error handling in both server manifest and direct modpack download scenarios
- Imported necessary dependencies for error dialog display and logging
Glavo
reviewed
Aug 13, 2025
| controller.onNext(); | ||
| } else { | ||
| reject.accept(e.getMessage()); | ||
| Logger.LOG.error("Failed to download modpack server manifest: ", e); |
There was a problem hiding this comment.
这里不是致命错误，请使用 warning 而不是 error。
而且请遵循代码中的惯例，静态导入 Logger.LOG。
Glavo
reviewed
Aug 21, 2025
| } | ||
| } catch (IOException e) { | ||
| reject.accept(e.getMessage()); | ||
| LOG.warning("Failed to download modpack: ", e); |
|
这个 PR 的处理方式看起来是错误的。原先就存在的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.