游戏下载页面添加搜索功能 #3517
Merged
游戏下载页面添加搜索功能 #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yushijinhun
reviewed
Jan 1, 2025
| toolbarPane.setContent(checkPane, ContainerAnimations.FADE); | ||
| centrePane.getContent().add(0, toolbarPane); | ||
|
|
||
| PauseTransition pause = new PauseTransition(Duration.millis(100)); |
There was a problem hiding this comment.
为什么要延时 100ms？即时显示搜索结果应该不会造成卡顿？
There was a problem hiding this comment.
搜索是个很快的过程，应该立即展示结果而不是等 0.1s，这是个肉眼可见的延迟。短时间内频繁输入也不会造成性能问题。
|
Hey, should this fix #3141? |
|
应当等待。主要的损耗在 JFX 排布 ListView 上而非搜索的逻辑层，这在模组很多的情况下较为明显
在 2025-01-02 12:52:48，"Haowei Wen" ***@***.***> 写道：
@yushijinhun commented on this pull request.
In HMCL/src/main/java/org/jackhuang/hmcl/ui/download/VersionsPage.java:
+
+ JFXButton searchButton = new JFXButton(i18n("search"));
+ searchButton.getStyleClass().add("jfx-tool-bar-button");
+ searchButton.setGraphic(wrap(SVG.MAGNIFY.createIcon(Theme.blackFill(), -1, -1)));
+ searchButton.setOnAction(e -> {
+ toolbarPane.setContent(searchBar, ContainerAnimations.FADE);
+ searchField.requestFocus();
+ });
+
+ checkPane.getChildren().add(checkPane.getChildren().size() - 1, searchButton);
+
+ centrePane.getContent().remove(checkPane);
+ toolbarPane.setContent(checkPane, ContainerAnimations.FADE);
+ centrePane.getContent().add(0, toolbarPane);
+
+ PauseTransition pause = new PauseTransition(Duration.millis(100));
搜索是个很快的过程，应该立即展示结果而不是等 0.1s，这是个肉眼可见的延迟。短时间内频繁输入也不会造成性能问题。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
yushijinhun
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_org.jackhuang.hmcl.Launcher_20250101153851.mp4