版本特定游戏设置从全局设置拷贝 #3509
Closed
版本特定游戏设置从全局设置拷贝 #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burningtnt
approved these changes
Dec 28, 2024
|
@Glavo Approved |
3gf8jv4dv
reviewed
Dec 28, 2024
There was a problem hiding this comment.
If you open HMCL for the first time (first generate hmcl.json) and then change the options for Global Settings, then enabling Instance-Specific Settings (first generate hmclversion.cfg) does not copy the options for Global Settings.
Works fine after restarting the launcher.
|
Thank you for raising attention to this issue. However, there are two small problems:
I have authored another commit to fix this (d5408c3). So I'm going to close this PR. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.