添加支持正则表达式搜索提示 #3222
Closed
添加支持正则表达式搜索提示 #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zkitefly
commented
Aug 11, 2024
•
zkitefly
commented
zkitefly
requested review from
burningtnt and
Glavo
and removed request for
burningtnt
hejiehao
reviewed
Aug 12, 2024
Co-authored-by: 何杰豪 <hejiehao12@126.com>
|
我认为添加这类提示会给普通用户带来困惑。这类提示应该放在文档中，没必要这样写出来。 |
我认为他们疑惑也不会造成什么问题，他们照样只会正常搜索，知道什么是正则表达式的也能得知这里支持正则 |
我不觉得这是好事，还是建议写文档里。 |
|
我比较好奇正则表达式的使用场景，因为普通搜索似乎能满足几乎所有需求？如果可以的话请麻烦列出一些 @zkitefly |
好像正则搜索确实场景挺少的，所以好像没太大理由说服了（ |
|
我是觉得文档里提一嘴完全够用，不需要这么搞。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.