-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CQL Changes #49
CQL Changes #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall these look great, tested and verified. There are just a few of the examples at the end that look like they don't line up with the example data?
*Example 8:* + | ||
Date 1: 2015-05-30 12:30:14 + | ||
Date 2: 2015-01-05 01:14:45 + | ||
Difference (years) = Duration (years) between 2015-01-01 00:00:00 and 2015-01-01 00:00:00 + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to line up with the dates in the example here?
*Example 9:* + | ||
Date 1: 2019-01-01 14:40:30 + | ||
Date 2: 2018-12-31 13:30:45 + | ||
Difference (years) = Duration (years) between 2019-01-01 00:00:00 and 2018:01:01 00:00:00 + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, the dates don't seem to line up with the example?
*Example 10:* + | ||
Date 1: 2013-05-30 12:15:15 + | ||
Date 2: 2013-01-15 13:01:45 + | ||
Difference (months) = Duration (months) between 2013-05-01 00:00:00 and 2013-01-01 00:00:00 + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one.
New Changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, tested and verified
No description provided.