Skip to content

Conversation

@ZackAttack614
Copy link
Collaborator

Overview

There exists a global variable, outputDegrees, whose purpose is now defunct. This PR removes the variable and associated control logic.

Affected Workflows

No workflows are affected by this removal.

Documentation Changes

No changes to documentation are required.

@ZackAttack614 ZackAttack614 requested a review from psavery January 14, 2026 21:35
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.08%. Comparing base (a66d698) to head (fadf74f).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
hexrd/core/material/crystallography.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #875      +/-   ##
==========================================
+ Coverage   69.06%   69.08%   +0.01%     
==========================================
  Files         147      147              
  Lines       22422    22401      -21     
==========================================
- Hits        15486    15475      -11     
+ Misses       6936     6926      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm doubtful anyone uses tempSetOutputDegrees. If anyone does, we can help them fix their scripts to work with this change.

@ZackAttack614 ZackAttack614 merged commit a088573 into master Jan 20, 2026
12 of 13 checks passed
@ZackAttack614 ZackAttack614 deleted the remove-output-degrees branch January 20, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants