fix: Trying to fix Canonica Ensemble Two State #839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing TODO in
PhysLean/StatisticalMechanics/CanonicalEnsemble/TwoState.leanGeneralization: Updated the twoState definition and IsFinite instance to accept two energy parameters,$E_{0}$ and $E_{1}$ .
Partition Function:
Energy Lemmas: Updated twoState_energy_fst and twoState_energy_snd to return E₀ and E₁ respectively.
Probabilities:
Mean Energy: Updated twoState_meanEnergy_eq to the general form:$\frac{E_0+E_1}{2} - \frac{E_1-E_0}{2} \tanh(\beta \frac{E_1-E_0}{2})$ .
Cleanup: Removed the TODO item.