-
Notifications
You must be signed in to change notification settings - Fork 4
First pass at cleaning hostnames out of the repo #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
adding launcher and cvmfsexec wrapper for Stampede2
add Frontera launcher and cvmfs wrapper
adding Theta specific files
Filebeat and first portion of kafka configs
Add template configuration files for integration test
Reorganized configuration templates and added condor_mapfile
Added instructions for basic setup of filebeat
Added steps for basic setup of digest topic logstash
Add documentation for store directory
update DNs
update proxy path
… into cloudBenchmarking
Adding folder with DE configuration templates
Update DE configs for master branch
StevenCTimm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this commit at all, this looks like 118 totally new files.
What is going on.. it says there are 118 file changes but they almost all appear
to be all new files with just minimal +/- how do we tell what you changed?
|
I agree, @StevenCTimm - so the BFG goes through all the past commits and any of the commits that had a hostname, would have to change, which means a new commit hash. I think this is why github thinks lots of files have changed that haven't. I'm going to go through and resolve all the merge conflicts, then see if there's a good way to figure out what actually needs reviewing and what doesn't. I did put in the description of the PR which files were actually marked by the tool as being changed, so maybe that's a start. |
|
Merge conflicts resolved. |
Given how this PR looks, we'll definitely need to go through and make sure things look the same. The BFG tool replaced hostnames with the string
***REMOVED***, which was changed in the following files:We definitely shouldn't rush this PR - it's worth it to take our time, and if another PR needs to go in before this, the instructions are pretty easy to replicate (https://rtyley.github.io/bfg-repo-cleaner/).