(Fix) Validation on updating group autogroup #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `autogroup` was false, blade doesn't render anything (empty string). By rendering it as `false` using the `Js` facade, the value of `autogroup` is set. The value is synced with the checkbox in the form. When it was blank, the checkbox value was errored. With the error fixed, the correct value is submitted and the validation passes. Fixes HDInnovations#4401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
autogroupwas false, blade doesn't render anything (empty string). By rendering it asfalseusing theJsfacade, the value ofautogroupis set. The value is synced with the checkbox in the form. When it was blank, the checkbox value was errored. With the error fixed, the correct value is submitted and the validation passes. Fixes #4401