Repository navigation
Conversation
The function declared its source pointer without an initializer and assigned it only when the property list carried a session token, but dereferenced it unconditionally. It now matches H5Pget_fapl_ros3_endpoint(), zeroing the destination buffer when no token is set. Adds a regression test that needs no network, and registers the ROS3 test programs with ctest when the s3proxy fixture is disabled so that they run in an ordinary build.
ajelenak
requested review from
fortnern,
glennsong09,
hyoklee,
jhendersonHDF,
lrknox,
mattjala and
vchoi-hdfgroup
as code owners
October 20, 2026 21:17
github-actions
Bot
removed request for
glennsong09,
hyoklee and
vchoi-hdfgroup
October 20, 2026 21:17
ajelenak
added
Component - C Library
Contributor
Review ChecklistThis PR touches the following areas. Each needs a sign-off
|
"small" means "char" on Windows apparently. 🤷♂️
hyoklee
requested changes
Oct 21, 2026
| endif () | ||
| endforeach () | ||
| else () | ||
| # Without the s3proxy fixture there is no a server for the networked S3 tests |
Member
There was a problem hiding this comment.
Without the s3proxy fixture -> Without the s3proxy fixture,
there is no a server -> there is no server
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function declared its source pointer without an initializer and assigned it only when the property list carried a session token, but dereferenced it unconditionally. It now matches
H5Pget_fapl_ros3_endpoint(), zeroing the destination buffer when no token is set.
Adds a regression test that needs no network, and registers the ROS3 test programs with ctest when the s3proxy fixture is disabled so that they run in an ordinary build.
Fixes #6757.