Skip to content

Reject find_package calls with non-standard capitalization #6603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattjala wants to merge 2 commits into
base: develop
Choose a base branch
from
+16 −0
Open

Reject find_package calls with non-standard capitalization #6603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c14ff83
Retain components when using non-uppercase package name in find_package
mattjala Aug 11, 2026
14fb362
Reject find_package requests with incorrect capitalization
mattjala Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions config/install/hdf5-config.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,22 @@ set (CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_CURRENT_LIST_DIR}/Modules")

string(TOUPPER @HDF5_PACKAGE@ HDF5_PACKAGE_NAME)

#-----------------------------------------------------------------------------
# Require that the package be requested as 'HDF5'.
#
# CMake's config-mode search matches the package name case-insensitively, so
# find_package (hdf5) succeeds, but CMake records that call's state
# under the caller's capitalization, which this file never reads. Require the
# uppercase name that FindHDF5.cmake also uses for consistency.
#-----------------------------------------------------------------------------
if (CMAKE_FIND_PACKAGE_NAME AND NOT CMAKE_FIND_PACKAGE_NAME STREQUAL HDF5_PACKAGE_NAME)
set (${CMAKE_FIND_PACKAGE_NAME}_FOUND FALSE)
set (${CMAKE_FIND_PACKAGE_NAME}_NOT_FOUND_MESSAGE
"HDF5 must be requested as \"${HDF5_PACKAGE_NAME}\", not \"${CMAKE_FIND_PACKAGE_NAME}\". Use find_package (${HDF5_PACKAGE_NAME} ...) instead."
)
return ()
endif ()

set (${HDF5_PACKAGE_NAME}_VALID_COMPONENTS
static
shared
Expand Down
Loading