Skip to content

Conversation

@menli820
Copy link
Contributor

@menli820 menli820 commented Dec 5, 2025

  1. Add new --tag-suffix CLI option to allow custom tag suffixes
  2. Modify tag generation in HCKTest to append suffix when provided
  3. Prevents naming conflicts when multiple users share a controller

@gemini-code-assist
Copy link

Summary of Changes

Hello @menli820, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the HCK-CI testing framework by introducing a new --tag-suffix command-line option. This option allows users to append a custom string to the automatically generated HCK-CI tags. The primary purpose of this change is to mitigate tag name conflicts, especially in shared controller environments, by ensuring that each test run can have a uniquely identifiable tag.

Highlights

  • New CLI Option: Introduced --tag-suffix as a new command-line interface option, allowing users to specify a custom suffix for HCK-CI tags.
  • Tag Generation Logic: Modified the HCKTest module to incorporate the provided --tag-suffix into the generated HCK-CI tag, appending it to the base tag if present.
  • Conflict Prevention: The addition of the tag suffix helps prevent naming conflicts when multiple users are sharing a test controller, ensuring unique identification for test runs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a --tag-suffix command-line option to prevent tag name conflicts, which is a valuable addition for environments with multiple users. The implementation is straightforward, adding the option in lib/cli.rb and applying it in lib/engines/hcktest/hcktest.rb. The code is clean and directly addresses the issue. I have one suggestion to improve the robustness of the suffix handling by trimming whitespace.

@menli820
Copy link
Contributor Author

menli820 commented Dec 5, 2025

@kostyanf14 please help review it when you free, thanks

./bin/auto_hck --verbose test --platform Win2025x64_host --drivers pvpanic --driver-path /usr/share/virtio-win/drivers/by-driver/pvpanic/2k25/amd64/ --tag-suffix run1

image image

  1. Add new --tag-suffix CLI option to allow custom tag suffixes
  2. Modify tag generation in HCKTest to append suffix when provided
  3. Prevents naming conflicts when multiple users share a controller

Signed-off-by: menli <menli@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants