-
Notifications
You must be signed in to change notification settings - Fork 18
VIRTWINKVM-1855:Add --tag-suffix option to prevent tag name conflicts #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
menli820
commented
Dec 5, 2025
- Add new --tag-suffix CLI option to allow custom tag suffixes
- Modify tag generation in HCKTest to append suffix when provided
- Prevents naming conflicts when multiple users share a controller
Summary of ChangesHello @menli820, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the HCK-CI testing framework by introducing a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a --tag-suffix command-line option to prevent tag name conflicts, which is a valuable addition for environments with multiple users. The implementation is straightforward, adding the option in lib/cli.rb and applying it in lib/engines/hcktest/hcktest.rb. The code is clean and directly addresses the issue. I have one suggestion to improve the robustness of the suffix handling by trimming whitespace.
|
@kostyanf14 please help review it when you free, thanks ./bin/auto_hck --verbose test --platform Win2025x64_host --drivers pvpanic --driver-path /usr/share/virtio-win/drivers/by-driver/pvpanic/2k25/amd64/ --tag-suffix run1
|
1. Add new --tag-suffix CLI option to allow custom tag suffixes 2. Modify tag generation in HCKTest to append suffix when provided 3. Prevents naming conflicts when multiple users share a controller Signed-off-by: menli <menli@redhat.com>
0af4e2a to
6a95a40
Compare

