Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Csv inherits shlex comment parsing, so an unquoted hash silently drops the remainder of a configuration value. For example, Csv()("https://example.com/#section,next") returns only ["https://example.com/"], and a value starting with # returns no fields.
Disable shlex commenters so hashes remain data, preserving the existing delimiter, quoting, stripping, cast and post-processing behavior. Regressions cover URL fragments, hashes at the beginning/middle of values and a custom delimiter with tuple processing.
Validation: two new tests fail before the change; the full Python 3.13 suite passes (69 tests).