Skip to content

GreenBushesReltoPageKveer#1693

Open
TheScarFr wants to merge 3 commits intoH-uru:masterfrom
TheScarFr:GreenBushesReltoPageKveer
Open

GreenBushesReltoPageKveer#1693
TheScarFr wants to merge 3 commits intoH-uru:masterfrom
TheScarFr:GreenBushesReltoPageKveer

Conversation

@TheScarFr
Copy link
Copy Markdown
Contributor

@TheScarFr TheScarFr commented May 10, 2025

Add a "Green Bushes" Relto Page in K'veer.
It adds back the Green Bushes from the Complete Chronicles' "Lush" Relto Page, but in a new Relto Page in K'veer, where was the Complete Chronicles' Lush Relto Page.
List of changes: List of changes.txt
Related Pull Request from moul-assets: H-uru/moul-assets#281

Add a "Green Bushes" Relto Page in K'veer.
It adds back the Green Bushes from the Complete Chronicles' "Lush" Relto Page, but in a new Relto Page in K'veer, where was the Complete Chronicles' Lush Relto Page.
Comment on lines +477 to +484
VAR BOOL psnlCalendarStone05[1] DEFAULT=0 # May - Descent (TreasureBookShaft)
VAR BOOL psnlCalendarStone06[1] DEFAULT=0 # June - Minkata (Kiva 2)
VAR BOOL psnlCalendarStone07[1] DEFAULT=0 # July - Ercana
VAR BOOL psnlCalendarStone08[1] DEFAULT=0 # August - Jalak
VAR BOOL psnlCalendarStone09[1] DEFAULT=0 # September - Teledahn
VAR BOOL psnlCalendarStone10[1] DEFAULT=0 # October - philRelto
VAR BOOL psnlCalendarStone11[1] DEFAULT=0 # November - GreatZero
VAR BOOL psnlCalendarStone12[1] DEFAULT=0 # December - Myst
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's defer these unrelated changes to another PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's defer these unrelated changes to another PR.

Done in: #1697

@TheScarFr
Copy link
Copy Markdown
Contributor Author

These 3 Pull Requests still haven't been merged... Have I done something badly? 🤔

@dpogue
Copy link
Copy Markdown
Member

dpogue commented Jul 15, 2025

Have I done something badly?

No, it's mostly a lack of review time/capacity, and that content changes are much harder to review than code changes. 😞

The SDL changes here look fine, but shouldn't be merged until someone's reviewed the content PR in moul-assets as well.

There are also conflicts on that content PR due to other bugfixes for Linking Book panels, and that involves more review time and some thinking to figure out how to best resolve those (in this case it shouldn't be hard to resolve, we have a script to generate the BkBookImages file now, but it will require some updates)

@TheScarFr
Copy link
Copy Markdown
Contributor Author

Ok, thank you dpogue. 🙂

@Hoikas
Copy link
Copy Markdown
Member

Hoikas commented Sep 7, 2025

This PR is blocked on an assets PR, which is blocked on me PRing the BkBookImages work. I'm almost done with the BkBookImages stuff, and I anticipate having that done in the new few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants