check curl result for return value 'false'#1
Open
ckressibucherTIM wants to merge 1 commit intoGuzzle3:masterfrom
Open
check curl result for return value 'false'#1ckressibucherTIM wants to merge 1 commit intoGuzzle3:masterfrom
ckressibucherTIM wants to merge 1 commit intoGuzzle3:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If curl_multi_exec returns false (probably because curl handle has already been closed with curl_multi_close) the method checkCurlResult did not throw an exception. I modified comparision of $code to type-strict to also throw an exception when $code === false.