Evaluate fixture definitions in adapter execution context#28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates fixture definition evaluation so fixture blocks run on the real framework execution context (RSpec example instance / Minitest test instance) while still routing
expose(...)back to the currentFixtureKit::Definition.Changes
lib/fixture_kit/adapters/rspec_adapter.rblib/fixture_kit/adapters/minitest_adapter.rblib/fixture_kit/cache.rbFixtureKit::Definition#evaluateto require acontextand execute the definition on that context.expose(...)delegation to the current definition.travel_toin RSpec integration).Definition#evaluate(context).Why
Fixture blocks could not call instance helper methods from the framework test context (e.g.
travel_tofrom included RSpec helpers), because definitions previously executed withself == FixtureKit::Definition.Validation
bundle exec rspec --fail-fast spec/unit/definition_spec.rb spec/unit/rspec_adapter_spec.rb spec/unit/minitest_adapter_spec.rb spec/unit/fixture_cache_spec.rb spec/integration/dummy_app_spec.rbFIXTURE_KIT_INTEGRATION_FRAMEWORK=minitest bundle exec rspec --fail-fast spec/integration/dummy_app_spec.rb