Fix duplicate DELETE statements for STI models sharing a table#22
Merged
Conversation
When multiple STI models share the same table (e.g. Car and Truck both using vehicles), statements_by_connection was generating a DELETE FROM for each model. The second DELETE would wipe records inserted by a sibling model earlier in the batch. Track deleted tables per connection with a Set so the DELETE is only emitted once per table. Also use `unscoped` in generate_statements so default scopes (including STI type conditions) don't filter out records during cache generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CarandTruckboth usingvehicles),Cache#statements_by_connectionwas generating aDELETE FROMfor each model. The second DELETE would wipe records inserted by a sibling model earlier in the batch.Setso the DELETE is only emitted once per table.unscopedingenerate_statementsso default scopes (including STI type conditions) don't filter out records during cache generation.Test plan
Vehicle,Car,Truck) to the dummy app🤖 Generated with Claude Code