Track SQL write events and verify cache dumping coverage#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FixtureKit::SqlSubscribersql.active_recordpayloadnameevents, including:CreateUpdate/Update AllDestroy/Delete AllInsert/Bulk InsertUpsert/Bulk UpsertDELETE FROM <table>firstINSERTSQL when presentINSERT OR IGNORE,ON CONFLICT DO NOTHING,INSERT IGNORE)nilinsert SQL for that modelTest Coverage Added
spec/unit/fixture_cache_spec.rbexecute_batchvisibility assumption (currently private)spec/unit/sql_subscriber_spec.rbSqlSubscriber.captureincludes changed model for supported write operationspayload[:name]format assumptions for supported operationsspec/dummy/fixture_kit/query_type_events.rbFKIT_ASSERT:QUERY_TYPES_CAPTUREDWhy
Testing
bundle exec rspec --fail-fastFIXTURE_KIT_INTEGRATION_FRAMEWORK=minitest bundle exec rspec --fail-fastbundle exec rspec --fail-fast spec/integration/dummy_app_spec.rbFIXTURE_KIT_INTEGRATION_FRAMEWORK=minitest bundle exec rspec --fail-fast spec/integration/dummy_app_spec.rb