Repository navigation
feat(SDK-1191): add unstable hook-backed payroll history - #2880
Open
krisxcrash wants to merge 3 commits into
Open
krisxcrash wants to merge 3 commits into
krisxcrash wants to merge 3 commits into
Conversation
serikjensen
reviewed
Oct 13, 2026
serikjensen
left a comment
Member
There was a problem hiding this comment.
Put a parking lot item on the schedule to discuss hooks direction! mentioned that i'm hesitant to roll these out given we are entering the partner stabilization phase
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a hook-backed PayrollHistory implementation behind the
payrollHistoryHooksunstable feature flag. The flag defaults to off, preserving the existing component behavior while the migration is reviewed.Changes
usePayrollHistory, following the existingUNSTABLE_PayrollEditEmployeepattern.QueryError, and remove the unusedstatus.isFetchingfield.Error boundary behavior
Query behavior matches legacy: payroll query errors reach the component boundary, initial wire-query errors reach it, and cached wire refresh errors remain invisible in the component. Headless consumers receive query errors through
errorHandling.Unexpected cancellation callback errors follow each implementation's boundary placement: legacy handles them at its outer boundary; the hooks implementation handles them at its component boundary and emits
ERRORwith the raw exception. Both record a failed submit metric. Regression coverage asserts this distinction explicitly.Related
Testing
To review, run
npm run storybookand open Domain / Payroll / UNSTABLE_PayrollHistory. ComparePayrollHistoryStory,AllStatusesShowcase,CancelDialog,EmptyState, andWithDateFilterwith the original stories. To exercise the public component's hook path, setunstableFeatures={{ payrollHistoryHooks: true }}onGustoProvider.