Skip to content

Commit

Permalink
Use a direct include of strings headers in ppapi/, printing/.
Browse files Browse the repository at this point in the history
BUG=247723
TEST=none
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16366009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205664 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
avi@chromium.org committed Jun 11, 2013
1 parent 516f018 commit 896d161
Show file tree
Hide file tree
Showing 24 changed files with 28 additions and 28 deletions.
2 changes: 1 addition & 1 deletion ppapi/native_client/src/trusted/plugin/pnacl_options.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ std::vector<char> PnaclOptions::GetOptCommandline() {
std::vector<nacl::string> tokens;

// Split the experimental_flags_ + the -On along whitespace.
// Mostly a copy of "base/string_util.h", but avoid importing
// Mostly a copy of "base/strings/string_util.h", but avoid importing
// base into the PPAPI plugin for now.
nacl::string delim(" ");
nacl::string str = experimental_flags_;
Expand Down
2 changes: 1 addition & 1 deletion ppapi/proxy/browser_font_resource_trusted.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#include "ppapi/proxy/browser_font_resource_trusted.h"

#include "base/string_util.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "ppapi/c/dev/ppb_font_dev.h"
#include "ppapi/shared_impl/ppapi_preferences.h"
Expand Down
2 changes: 1 addition & 1 deletion ppapi/proxy/ppapi_messages.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "base/files/file_path.h"
#include "base/process.h"
#include "base/shared_memory.h"
#include "base/string16.h"
#include "base/strings/string16.h"
#include "base/sync_socket.h"
#include "base/values.h"
#include "gpu/command_buffer/common/command_buffer.h"
Expand Down
2 changes: 1 addition & 1 deletion ppapi/proxy/ppb_var_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include <string>
#include <vector>

#include "base/string_number_conversions.h"
#include "base/strings/string_number_conversions.h"
#include "base/threading/platform_thread.h"
#include "ppapi/c/pp_var.h"
#include "ppapi/c/ppb_var.h"
Expand Down
2 changes: 1 addition & 1 deletion ppapi/proxy/ppp_messaging_proxy_perftest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#include "base/command_line.h"
#include "base/perftimer.h"
#include "base/string_number_conversions.h"
#include "base/strings/string_number_conversions.h"
#include "ppapi/c/ppp_messaging.h"
#include "ppapi/proxy/ppapi_proxy_test.h"
#include "ppapi/proxy/serialized_var.h"
Expand Down
2 changes: 1 addition & 1 deletion ppapi/shared_impl/dictionary_var.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include "ppapi/shared_impl/dictionary_var.h"

#include "base/memory/ref_counted.h"
#include "base/string_util.h"
#include "base/strings/string_util.h"
#include "ppapi/shared_impl/array_var.h"
#include "ppapi/shared_impl/ppapi_globals.h"
#include "ppapi/shared_impl/var_tracker.h"
Expand Down
2 changes: 1 addition & 1 deletion ppapi/shared_impl/ppb_gamepad_shared.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#define PPAPI_SHARED_IMPL_PPB_GAMEPAD_SHARED_H_

#include "base/atomicops.h"
#include "base/string16.h"
#include "base/strings/string16.h"
#include "ppapi/c/ppb_gamepad.h"
#include "ppapi/shared_impl/ppapi_shared_export.h"

Expand Down
2 changes: 1 addition & 1 deletion ppapi/shared_impl/private/net_address_private_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

#include "base/basictypes.h"
#include "base/logging.h"
#include "base/stringprintf.h"
#include "base/strings/stringprintf.h"
#include "build/build_config.h"
#include "ppapi/c/pp_var.h"
#include "ppapi/c/private/ppb_net_address_private.h"
Expand Down
4 changes: 2 additions & 2 deletions ppapi/shared_impl/var.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
#include <limits>

#include "base/logging.h"
#include "base/string_number_conversions.h"
#include "base/string_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "ppapi/c/pp_var.h"
#include "ppapi/shared_impl/ppapi_globals.h"
#include "ppapi/shared_impl/var_tracker.h"
Expand Down
4 changes: 2 additions & 2 deletions ppapi/tests/test_case.cc
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ std::string StripTestCase(const std::string& full_test_name) {
// the bool indicating whether the test should be run.
void ParseTestFilter(const std::string& test_filter,
std::map<std::string, bool>* remaining_tests) {
// We can't use base/string_util.h::Tokenize in ppapi, so we have to do it
// ourselves.
// We can't use base/strings/string_util.h::Tokenize in ppapi, so we have to
// do it ourselves.
std::istringstream filter_stream(test_filter);
std::string current_test;
while (std::getline(filter_stream, current_test, ',')) {
Expand Down
2 changes: 1 addition & 1 deletion ppapi/thunk/enter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include "base/bind.h"
#include "base/logging.h"
#include "base/message_loop.h"
#include "base/stringprintf.h"
#include "base/strings/stringprintf.h"
#include "base/synchronization/lock.h"
#include "ppapi/c/pp_errors.h"
#include "ppapi/shared_impl/ppapi_globals.h"
Expand Down
4 changes: 2 additions & 2 deletions printing/backend/cups_helper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

#include "base/file_util.h"
#include "base/logging.h"
#include "base/string_number_conversions.h"
#include "base/string_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/string_split.h"
#include "base/values.h"
#include "googleurl/src/gurl.h"
Expand Down
2 changes: 1 addition & 1 deletion printing/backend/print_backend.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <vector>

#include "base/memory/ref_counted.h"
#include "base/string16.h"
#include "base/strings/string16.h"
#include "printing/print_job_constants.h"
#include "printing/printing_export.h"

Expand Down
2 changes: 1 addition & 1 deletion printing/backend/print_backend_cups.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#include "base/file_util.h"
#include "base/lazy_instance.h"
#include "base/logging.h"
#include "base/string_number_conversions.h"
#include "base/strings/string_number_conversions.h"
#include "base/synchronization/lock.h"
#include "base/values.h"
#include "googleurl/src/gurl.h"
Expand Down
2 changes: 1 addition & 1 deletion printing/backend/win_helper.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

#include <string>

#include "base/string16.h"
#include "base/strings/string16.h"
#include "base/win/scoped_handle.h"
#include "printing/printing_export.h"

Expand Down
2 changes: 1 addition & 1 deletion printing/image.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "base/file_util.h"
#include "base/md5.h"
#include "base/safe_numerics.h"
#include "base/string_number_conversions.h"
#include "base/strings/string_number_conversions.h"
#include "printing/metafile.h"
#include "printing/metafile_impl.h"
#include "third_party/skia/include/core/SkColor.h"
Expand Down
2 changes: 1 addition & 1 deletion printing/print_dialog_gtk_interface.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#ifndef PRINTING_PRINT_DIALOG_GTK_INTERFACE_H_
#define PRINTING_PRINT_DIALOG_GTK_INTERFACE_H_

#include "base/string16.h"
#include "base/strings/string16.h"
#include "printing/printing_context_gtk.h"
#include "ui/gfx/native_widget_types.h"

Expand Down
2 changes: 1 addition & 1 deletion printing/print_settings.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include <string>

#include "base/string16.h"
#include "base/strings/string16.h"
#include "printing/page_range.h"
#include "printing/page_setup.h"
#include "printing/print_job_constants.h"
Expand Down
2 changes: 1 addition & 1 deletion printing/print_settings_initializer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include <string>

#include "base/i18n/time_formatting.h"
#include "base/string_number_conversions.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time.h"
#include "base/values.h"
Expand Down
2 changes: 1 addition & 1 deletion printing/print_settings_initializer_gtk.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include <gtk/gtk.h>
#include <gtk/gtkunixprint.h>

#include "base/string16.h"
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
#include "printing/print_settings.h"
#include "printing/units.h"
Expand Down
4 changes: 2 additions & 2 deletions printing/printed_document.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
#include "base/i18n/time_formatting.h"
#include "base/lazy_instance.h"
#include "base/message_loop.h"
#include "base/string_util.h"
#include "base/stringprintf.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "printing/page_number.h"
#include "printing/printed_page.h"
Expand Down
2 changes: 1 addition & 1 deletion printing/printed_document.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <map>

#include "base/memory/ref_counted.h"
#include "base/string16.h"
#include "base/strings/string16.h"
#include "base/synchronization/lock.h"
#include "printing/print_settings.h"
#include "ui/gfx/native_widget_types.h"
Expand Down
2 changes: 1 addition & 1 deletion printing/printed_pages_source.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#ifndef PRINTING_PRINTED_PAGES_SOURCE_H_
#define PRINTING_PRINTED_PAGES_SOURCE_H_

#include "base/string16.h"
#include "base/strings/string16.h"

namespace printing {

Expand Down
2 changes: 1 addition & 1 deletion printing/printing_context.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#include "base/basictypes.h"
#include "base/callback.h"
#include "base/string16.h"
#include "base/strings/string16.h"
#include "printing/print_settings.h"
#include "ui/gfx/native_widget_types.h"

Expand Down

0 comments on commit 896d161

Please sign in to comment.