Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always return state and don't assign state object #38

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

tschaka1904
Copy link

This is removing any state = * assignments and unnecessary return state. Part of #37

The reducer/s will take the state without state being manually assigned. The return is only needed, if we actually want to replace the entire state (e.g. state = action.props or state = merge(x, y))

@moromis
Copy link

moromis commented Oct 26, 2022

Have you verified everything works, especially stuff like the opacity slider? If it does I'll approve this, I just thought I had to return for some reason (though that's not usually how Redux works, for sure)

@tschaka1904 tschaka1904 merged commit 0f62cfe into GumusLab:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants