how to improve diff effect with key

[wangxi761]

can we mark some Syntax node as the key ,such as json key ，so we can match it more quickly

[wangxi761]

It doesn't look right

[jrfaller]

Hi!

Unfortunately our json parser is in fact the Mozilla rhino js parser. Therefore it might not be perfect for json files. I am not sure to understand well what is your proposal to improve the situation?

Cheers!

[wangxi761]

I have read gumtree algorithm ， and it seem compare for Keyless Data ,
In many cases，at parse phase ,we could mark some Syntax with key 。
such as json key, method name and so on
in match phase , it will be more Precise and more fast

[jrfaller]

In fact I think this is not really keyless since the key is contained in the subtree corresponding to the property declaration, somethig like:

ObjProp
  Key
    Name "foo"
  Value
    Value "bar"

Therefore it is taken into account at some point.

However you would prefer something more direct like:

ObjProp
  Key "foo"
  Value "bar"

(note that these are not the real names of ast nodes, just made up for the sake of the example).

Is it that?

[jrfaller]

Any follow-up on this issue ?