Boilerplate refactor (#8820) #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* boilerplate refactor wip * rename files * make switching between old/new easier * refactor and modernize boilerplate-generator * add cordova template code * delete old boilerplate-generator * small style fixes * address comments * address review comments again * remove boilerplate generated-by comment * delete spacebars templates * add boilerplate-generator-tests * bump boilerplate-generator version * dummy commit * Revert "dummy commit" This reverts commit 54fe867. * update tests * refactor parameter destructuring * fix style * modernize boilerplate generator a bit * refactor boilerplate-generator * fix web browser template * refactor boilerplate-generator-tests * rename files using hyphens * Remove spaces after object-shorthand method names. Per the comment in #8820 (comment) Previously, only the `constructor` method was addressed and this expands on that. * Add some space for legibility between conditionals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boilerplate refactor wip
rename files
make switching between old/new easier
refactor and modernize boilerplate-generator
add cordova template code
delete old boilerplate-generator
small style fixes
address comments
address review comments again
remove boilerplate generated-by comment
delete spacebars templates
add boilerplate-generator-tests
bump boilerplate-generator version
dummy commit
Revert "dummy commit"
This reverts commit 54fe867.
update tests
refactor parameter destructuring
fix style
modernize boilerplate generator a bit
refactor boilerplate-generator
fix web browser template
refactor boilerplate-generator-tests
rename files using hyphens
Remove spaces after object-shorthand method names.
Per the comment in
meteor#8820 (comment)
Previously, only the
constructormethod was addressed and this expandson that.
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first (in the meteor/meteor-feature-requests repository) and discuss your ideas there before implementing them.
Always follow the contribution guidelines when submitting a pull request. In particular, make sure existing tests still pass, and add tests for all new behavior. When fixing a bug, you may want to add a test to verify the fix.